Closed (won't fix)
Project:
Markdown with SmartyPants
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 Feb 2008 at 22:56 UTC
Updated:
22 Feb 2008 at 13:32 UTC
Jump to comment: Most recent file
Comments
Comment #1
milianw commentedI've made some change to my patch. The "geshi compliant" option is gone, I call
filter_list_format($format)now to check this on the fly.I wonder wether an additional note should be shown to the user, that geshi should be rearranged so that it is called after marksmarty?
New patch is attached.
Comment #2
moshe weitzman commentedThis patch is quite ugly with its conditionals strewn about. I really don't likemingling filter code like this. GeSHI before markdown looks fine to me. In this case, simply don't use the markdown code block feature. It really doesn't do anything for you that you can't do with a [code] tag or with [blockcode]
Comment #3
milianw commentedOk, so I don't have a chance to include this into trunk. A pity.
What about a Readme/Faq entry that GeSHi must be called before markdown. Where would be the correct position for this?
Comment #4
moshe weitzman commentedI added a note to the project page for markdown. The project page of GeSHi says that it has code to help with "filter conflict". Not sure what thats about.
Comment #5
milianw commentedI'll ask the GeSHi guys if this could be implemented. Is "won't fix" the correct status for this? Or should it be closed?