I would like to assume (co-)maintainership of this module, in order to fix the recently announced security issue that led to this module being marked as abandoned. I posted my proposed solution at https://security.drupal.org/node/71639#comment-71358.

Comments

pfrenssen’s picture

Status: Active » Reviewed & tested by the community

I support the application. Looking at ergonlogic's profile it seems like the module will be in very capable hands.

recrit’s picture

@ergonlogic - that link does not go anywhere. Can you post the patch or proposed solution?

ergonlogic’s picture

The link points to the issue where this was originally discussed. The module's current maintainers should have access.

Anyway, the plan is for Dave Reid to publish https://drupal.org/sandbox/davereid/1332490 as a full module, and provide a stable release. We have a patch for content_lock that has that project as a dependency. Once it's published, we can apply the patches to content_lock and make a new release.

I haven't been granted maintainer rights on this project yet, and I'd like to give the current maintainer a chance to respond. I've contacted him directly via his d.o contact form. If there's no response, I'll ask to have the project ownership transferred to me.

grendzy’s picture

ergonlogic: The security team has received messages from several other community members interested in helping out. I have directed them here, so you know. I think it would be OK to post a patch for review since the issue is public now. Are you interested in additional co-maintainers?

Folks can also help out by providing reviews of https://drupal.org/sandbox/davereid/1332490. Thanks!

dave reid’s picture

@ergonlogic When did you say you contacted me via the Drupal.org contact form? I don't have any incoming e-mail from you in the last week, even in my Gmail spam folder.

ergonlogic’s picture

@Dave Reid, I didn't contact you directly, only through the security.drupal.org issue and #2207009: Add ergonlogic as co-maintainer. Sorry for the mixup. By 'this project' I was referring to content_lock, and the maintainer I contacted was ohnobinki.

@grendzy, for the foreseeable future, I'll only have the time to minimally maintain this module. That is, to keep it secure and fix any egregious bugs. Even at that, I hadn't planned to keep up the 6.x branch. So there's plenty of room for others who may have more time, or the inclination to further develop it. That said, I encourage any potential co-maintainers to submit issues similar to this one. to express their interest publicly :)

I've attached the patch by ohnobinki from the security issue. Dave Reid also suggested just implementing native token support in content_lock, rather than depending on protection_menu_token.module.

ergonlogic’s picture

Title: Add ergonlogic as co-maintainer » Transfer ownership of 'Content Locking' to ergonlogic
Project: Content locking (anti-concurrent editing) » Drupal.org site moderators
Component: Miscellaneous » Project ownership
Status: Reviewed & tested by the community » Active

Please transfer ownership of https://drupal.org/project/content_lock to ergonlogic, so as to fix a security issue currently making it 'unsupported'. See SA-CONTRIB-2014-024 - Content Lock - CSRF for details.

As noted earlier in the issue, I have attempted to contact the module's maintainer without receiving any response. Also, there is a workable solution to the security issue that can allow this project to be re-published.

markpavlitski’s picture

We use this module on a number of sites and are keen to see it restored.

ergonlogic seems like a good candidate to take over the module.

It would be good to see a solution to this that doesn't rely on a sandbox project though.

pfrenssen’s picture

Status: Active » Reviewed & tested by the community

I also support the application of ergonlogic to become the new maintainer of the Content Locking module.

designerbrent’s picture

I would love to see ergonlogic get ownership of this project so it can be patched and restored.

dddave’s picture

Status: Reviewed & tested by the community » Needs work

Sorry to be a party pooper here. Before anything can be transferred the proposed solution for the SA needs to be approved by the security team. As far as I can see this has not happened yet, or has it? Wouldn't you need a release of Dave Reid's module, too? Am I missing something here?

mirie’s picture

@ergonlogic, I'm interested in helping out with the maintenance of this module. What can I do to move this process along now?

recrit’s picture

@all: A patch not dependent on protection_menu_token has been created at #2238703: Fix SA-CONTRIB-2014-024. Please review to resolve this security issue.
I posted in the module's issue queue since the SA is public now and so others using the module can find it easier.

Project: Drupal.org site moderators » Drupal.org project ownership
Component: Project ownership » Ownership transfer
fuzzy76’s picture

Status: Needs work » Active

The proposed solution has been here for months now, let's get this moving :)

jenlampton’s picture

Status: Active » Reviewed & tested by the community

I've reviewed the solution over in #2238703: Fix SA-CONTRIB-2014-024 and it looks like a good one. Do we need to get the security team to sign off on that solution before this project can be transferred? What's the process for moving this forward? (updating status to see if that does the trick).

dddave’s picture

As far as I know this needs to be approved by somebody of the sec team. Especially since this approach is different from the one proposed at the beginning of this discussion.

pfrenssen’s picture

Component: Ownership transfer » Abandoned/unsupported projects
mrconnerton’s picture

@pfrenssen why was this set to "Abandoned/unsupported projects"? As far as I can tell ergonlogic still wants to be maintainer and many of us would like the sec team to approve the fix.

What's actually the nexts step in this process?

pfrenssen’s picture

@mrconnerton, see the process described at Dealing with unsupported (abandoned) projects.

The next step is just to approve the maintainership. All requirements are met. There is some unknown factor holding up this transfer at the d.o side. Maybe the drama that surrounded the departure of the original maintainer left a sour taste with the people involved and they rather ignore it than opening that can of worms again.

Keep in mind that it's been many months since @ergonlogic applied to be the new maintainer and he might have changed his mind in the meanwhile.

dddave’s picture

I can transfer the module in no time but I was under the impression that this needed security sign-off (#17). Is this not the case? If so, why not? Nobody cared to explain that.
No relation to any drama.

mrconnerton’s picture

I assume that the security team needs to sign off the commit that fixes the security issue, but don't see why they would prevent a maintainership change. I do agree @ergonlogic needs to let us know if he wants to maintain the module or not at this point.

pfrenssen’s picture

Oh I didn't realize that, how can we bring this to the attention of the security team?

silverwing’s picture

Easiest way would be to ping a security team member on IRC https://security.drupal.org/team-members - dww and greggles are often available (I think.)

dddave’s picture

Special note on projects marked unsupported for security reasons

If you wish to take over a project that is marked as unsupported for security reasons, post a patch to the project's issue queue which addresses the vulnerability and reference that patch in your request to take over the project. Then send a message to security@drupal.org asking for a security team member to confirm in your request issue that your patch resolves the security issue. Refer to the security announcement which led to the project becoming unsupported for information about the vulnerability. Contact the security team if you are unsure about the nature or scope of the security issue or need additional information.

About the ownership transferal of projects iced for security reason.

ergonlogic’s picture

Several others have stepped up in the time since I offered to take over maintainership, and one of them is probably a better choice. Several appear to have plans to continue development, whereas I'd only ever intended to minimally maintain it (i.e. keep it secure). That said, if no one else is available, I'll make an effort to carve out some time for it.

larowlan’s picture

Are you still blocked on security team sign-off?
Happy to take a look.

larowlan’s picture

Reviewed the patch at #2238703-20: Fix SA-CONTRIB-2014-024 only minor comment cleanup needed that I can see.

kattekrab’s picture

@ergonlogic - perhaps you could take this on, and add some of those others as co-maintainers?

It would be great if you could take this on - this is a really useful module. You'd have a lot of happy fans :)

Thanks for the patch too!

dddave’s picture

Status: Reviewed & tested by the community » Fixed

I've transferred the module to ergonlogic but left the warning on the project page. ergonlogic can edit that (the whole project page needs an overhaul) after commit. If there is anything left to do from my side, please let me know.

rockie667’s picture

Hello,

can somebody please tell me how to get the complete module, since the project page still doesn't show the links to the downloads.

I really would be glad to get a functioning version of this useful module!

Or maybe somebody can supply us with the current state of the module!

Thanks a lot!!!!

dddave’s picture

There is currently no working module because the patch hasn't been commited yet.

ergonlogic’s picture

I'd missed that the transfer happened. Thanks for the head's up, @kattekrab. I'll look into it today.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.