From http://drupal.org/node/221016.

I just changed it and it appears that cvslog doesn't respect that value. So...I'm creating this to hold a patch that would update it to do so.

CommentFileSizeAuthor
#5 cvs-221295-5-sitewide_rss_setting.patch1.58 KBgreggles
#3 sitewide_rss_setting_221295.patch1.43 KBgreggles

Comments

jpetso’s picture

jpetso commented

cvs.module has its own pager setting with variable name 'cvs_pager', set to 10 by default. I don't currently remember if there's a UI somewhere to set this (either in cvs.module or in project.module, or not at all) but if you change that setting, you get more commits per page.

I'm not sure if this should follow the sitewide "Number of items per feed" because commits are a fundamentally different type of content than posts are.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Yes - I realized after submitting that I should have said "or have its own setting exposed".

I don't care so much whether the pager respects it - but the rss feed is quite important. If this variable is currently overloaded and used in both situations then I think we should split it.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new sitewide_rss_setting_221295.patch1.43 KB

Well, here is a patch which checks whether this is an rss feed and, if so, uses the sitewide setting and, if not, uses the cvs_pager.

I looked around my local project* installation to see where the cvs_pager was used/created and couldn't find it so I think this is a variable that's not exposed.

The patch is against HEAD.

jpetso’s picture

jpetso commented

Ok, fine from my side. I committed a similar fix to Version Control API's Commit Log, cvs.module needs to be fixed by someone else.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new cvs-221295-5-sitewide_rss_setting.patch1.58 KB

Discussed with Chad. He pointed out that this isn't e_all safe, so I fixed that and also fixed the line that I had copied ;)

Thanks for the review.

hunmonk’s picture

hunmonk commented
Status: Needs review » Fixed

code looks good. tested out perfectly. committed to 5.x and HEAD, deployed on d.o

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks kindly, hunmonk. My feedreader is quite happy now ;)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.