This is my first time contributing something so I am unsure how to do this.

I have ported Automated Logout to core 6, here is the tarball. I changed the countdown timer to use Javascript Countdown Timer instead, this seems to provide less problems with IE 7 at least.

CommentFileSizeAuthor
#6 autologout_upgrade_to_core_6.patch13.07 KBjrglasgow
#1 autologout_upgrade_to_core_6.patch10.86 KBjrglasgow
autologout-6.x.tar_.gz11.76 KBjrglasgow

Comments

jrglasgow’s picture

jrglasgow commented
Title: Port to core 6 » Port to core 6 - patch
Status: Active » Needs review
StatusFileSize
new autologout_upgrade_to_core_6.patch10.86 KB

I'm just learning how to contribute. Here's my patch.

AjK’s picture

AjK commented

Thanks very much! I'll review and test shortly.

jvandervort’s picture

jvandervort commented

If you are including support for Javascript Countdown Timer, you may way to use the 2.x branch instead of the 1.x branch.
The tags would need to be changed a little.

the name= attribute of the span tags changed to class=

AjK’s picture

AjK commented

@jrglasgow - I see you recently applied for a CVS account but didn't provide enough details to aquire one. Well, I approved your account and added you to this project (autologout) as a co-maintainer. So now you can commit to this project directly. Try to treat it nicely, thanks!

@jvandervort - I see you have an interest in this module also. You too now have CVS write access. Yes, I hand it out like lollypops but that's the beauty of CVS (or SVN), you can roll back any mess!

I'd rather have people who are interested in teh module partake than turn away good offers of help. Thanks to you both.

jvandervort’s picture

jvandervort commented
Version: master » 5.x-1.3

Patch looks to be against 5.x-1.3

jrglasgow’s picture

jrglasgow commented
Version: 5.x-1.3 » master
StatusFileSize
new autologout_upgrade_to_core_6.patch13.07 KB

This is my first attempt to patch. I'm beginning to understand more. This patch is against HEAD.

jvandervort’s picture

jvandervort commented

Committed the first version of the patch to a new branch: DRUPAL-6--1
AjK can make a release for 6.x once he thinks it is worthy.

jrglasgow’s picture

jrglasgow commented
Status: Needs review » Fixed
jrglasgow’s picture

jrglasgow commented
Status: Fixed » Closed (fixed)