Posted by ryo on February 16, 2008 at 3:47pm
| Project: | Simplenews |
| Version: | 5.x-1.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Although "From name" is specifed in "Sender information" at /admin/content/newsletters/settings,
it doesn't show up in the mail...
Comments
#1
This is occurring for me also in the latest 5.x stable version. The from-name is important, as many spam filters will mark it as spam if there is no from name. Yahoo is marking my simplenews mails as spam, and SpamAssassin is also giving it a bad spam score for checking true for the "NO_REAL_NAME" check.
#2
Changing version back to original poster's setting. I have tested this and confirmed it to be a bug on 5.x-1.3 also.
#3
It looks like the email address is being inserted in the From: field, but not the name. It needs a name to get past the SpamAssassin check I believe.
#4
I installed the mime module and it works now. I think that the from name might not be properly mime encoded otherwise, but I have not confirmed this. This post made me suspect that there may be something wrong with simplenews's from field that mime module is correcting: http://drupal.org/node/238735.
#5
This may be caused by missing settings and un logical behavior of simplenews.
When there is no site email address set (/admin/settings/site-information) the newsletter specific from name and from address have no default value. With the attached patch these newsletter specific settings default to the simplenews general from name and address which default in its turn to the site name and address.
Patch committed.
#6
Still, the sender's name doesn't show up in the received Email even though it is specified at "sender name" in "/admin/content/newsletters/settings" (in Japanese - double byte character language).
#7
@ryo:
1. Are you using plain or html text emails? Does it fail on plain text?
2. Please give examples of emails send by Drupal (using name + email address) that does give the right result. Preferably examples from Drupal core.
3. Give an example of a name.
#8
@Sutharson:
Thanks for taking care.
1. We're now using plain text emails. As webavant mentioned, when we use html text, things went well. For my client's reason, we changed it into plain text, then the issue happened.
2. I'm sorry but what do you mean by that? Do you want for example mails sent by core contact module? And how could I give it to you?
3. What name? Are you saying site's name in Japanese?
#9
Re. 2 It is helpfull for me if you have an example situation of emails send by core where the To address has the format of "name" is used and received correctly. For example the email via private form.
Re. 3. Yes. To enable me to test with real data.
#10
After a bit more digging and the kind assistance of ryo I found the cause.
The attached patch solves it. Tested by ryo (thanks!) and now committed.
#11
Automatically closed -- issue fixed for two weeks with no activity.