alter drupal_to_js() to use json_encode()
pwolanin - February 16, 2008 - 18:08
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | javascript |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Since we require PHP 5.2, we can rely instead on the built-in function json_encode()
http://www.php.net/manual/en/function.json-encode.php
Someone who knows more about the AHAH functionality should look at this- - also this change seem to break upload module's attach button, which suggests that there is some difference between the output of drupal_to_js() and json_encode()
| Attachment | Size |
|---|---|
| remove-drupal_to_js.patch | 5.19 KB |
#1
Ahh - investigation reveals that json_encode() does not escape < > or & the way drupal_to_js() does - thus there are HTML errors when the AHAH tries to get the updated form.
#2
new patch - leave drupal_to_js() so we can escape to HTML-safe, but use the built-in json_encode() for efficiency.
With this the upload form AHAH, at least, seems to work right.
#3
Subscribing. Looking good! :)
#4
tested with PHP 5.2.4, Mac 10.4, FF 2.0 and Safari 3.0, apache 1.3:
book, upload, poll module AHA all works fine, user autocomplete field in node form works fine.
#5
Tested also in ie6 and ie7. Poll, book, upload and autocomplete all work.
#6
I committed this to CVS HEAD. Thanks.
#7
Note: I asked Steven about why he introduced the escaping in the first place, since everything seems to work fine without. The reason he put that into place is because it was required for the upload.module's iframe mechanism. This however, has been removed (and replaced with AHAH). That means, that we can get rid of the encoding after we tested that everything still works.
#8
@kk - during my testing it did NOT work when the escaping was removed. See the first patch.
#9
back to fixed
#10
Automatically closed -- issue fixed for two weeks with no activity.