I ran the coder (code review) module and it led me through some changes that got close to it working on drupal 6.

Remaining issues are:


Line 116: new hook_theme() function is required to register theme_ functions (Drupal Docs http://drupal.org/node/114774#theme_registry)
function theme_quicktags_textfield($element) {

severity: criticalLine 47: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
  if ($may_cache) {

severity: criticalLine 48: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
    $items[] = array(

severity: criticalLine 54: The menu system has been completely over-hauled in 6.x. (Drupal Docs http://drupal.org/node/102338)
    $items[] = array(
CommentFileSizeAuthor
#5 quicktags_drupal6.patch3.77 KBquicksketch
#3 quicktags_drupal6.patch2.86 KBnaheemsays
quicktags.diff7.05 KBreikiman

Comments

tcblack’s picture

tcblack commented
Category: bug » task

Moving from bug to task since needing a 6.x version is not exactly a bug.

naheemsays’s picture

naheemsays commented

subscribing.

naheemsays’s picture

naheemsays commented
StatusFileSize
new quicktags_drupal6.patch2.86 KB

Attached is a patch without the coder style fixes. It should be more or less complete.

however, it does not work - an additional textarea is shown instead of the buttons. I think this may be a javascript error.

naheemsays’s picture

naheemsays commented
Status: Active » Needs work
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new quicktags_drupal6.patch3.77 KB

Looks like the new way Drupal handles JavaScript doesn't agree with Quicktags' dynamic JavaScript file. We need to explicitly tell it not to try to aggregate the JavaScript or errors will go crazy.

Also, looks like the new drupal_get_js() will no longer take a query string like "?q=quicktags" as a valid JavaScript location. I removed the "?q=" for now (meaning you need a server that supports clean URLs). A cleaner solution would be to either add inline JavaScript, or save a physical file into the files directory that the aggregater can agree with.

However, this patch is fully working and changes as little code as possible. The fix needed to cleanly add the dynamic JavaScript file should be done in both the 5 and 6 version in a later patch.

heirecka’s picture

heirecka commented
Status: Needs review » Reviewed & tested by the community

I can confirm the patch is working, although there are two remaining issues:

  • Firebug tells me about two errors on sites without the quicktags toolbar: edCanvas and edToolbar are not defined. Don't know whether this could be avoided.
  • the patch fails on the *.info files
paddes’s picture

paddes commented

Hello,
could somebody please upload a patched version of the module?
I am desperately trying to get this running on drupal 6 :)

thanks a lot,
paddes

naheemsays’s picture

naheemsays commented

You may wanna try the markitup module. It and this module are very similar when it comes to the end user.

http://drupal.org/project/markitup

paddes’s picture

paddes commented

thanks a lot, but I found something better. The BUeditor.
http://drupal.org/project/bueditor

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Reviewed & tested by the community » Closed (won't fix)

This version of quicktags is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.