It would be nice if a user with the "assign patches" role could assign patches to users that have a "patch reviewer" role. This would hopefully improve the workflow for patches on drupal.org. "patch reviewers" could maybe self-assing this role by checking a box in their user profile.

I'd be willing to implement the feature if there is demand.

CommentFileSizeAuthor
#5 issue.inc_0.patch1.67 KBfgm

Comments

Aran Deltac’s picture

I've put a little bit of time in to making this happen. I'm still getting the feal for where everything is placed, but it doesn't seem like its much work. If you decide to impliment this I would like the feature "self-assing this role by checking a box in their user profile" to be optional. Also, by "role", don't you mean "permission" (as in hook_permissions)?

killes@www.drop.org’s picture

Would be nice if you could implement this.

Yes, I meant permission.

moshe weitzman’s picture

Title: Let admins assign issues to patch reviewers » Let admins assign issues to people

a bit more generic

dan_aka_jack’s picture

Yes, I agree - it would be great if users with sufficient permissions could assign issues to other people.

fgm’s picture

Status: Active » Needs review
StatusFileSize
new1.67 KB

I just made a patch the will suggest users having the "create project issues" permissions in that box. That seemed the most logical existing permission, to avoid adding yet one more perm.

killes@www.drop.org’s picture

Status: Needs review » Needs work

This needs a lot of work. The proper way to address this would be an autocompletion field.

dan_aka_jack’s picture

fgm, thanks for the patch - I'm using it right now and it's working very well for me.

The proper way to address this would be an autocompletion field

Autocompletion would certainly be appropriate on a site with more than, say, 20 users. But on a site with less than 20 years, I think some people would prefer a drop-down box. I would propose that the "perfect" system would allow administrators to choose between an autocompetion field and a drop-down box.

Also, it would be great if it were possible to assign issues to multiple people.

fgm’s picture

Thanks Dan.

Note that in this version (that still needs work, as lists can become too large on huge sites like drupal.org), you must first unassign an issue before you can assign it to someone else. Removing the lines:

    if ($user->uid == $node->assigned) {
      $assigned = array(0 => t('Unassign'), $user->uid => $user->name);
    }
    else {

and the closing brace, still in project_issue_form allows issue reassignment at will.

dww’s picture

another approach: killes wants me to work on locking down drupal.org's contrib cvs repository so that only the owner of a given project, and a selected group of blessed maintainers, has cvs permissions to commit or tag files in a given project. this would require a new setting in the project node's edit page to define the maintainers (which would be another good place for an autocompletion field). once there was such a list associated with each project, that'd be the obvious group to include in a simple drop-down menu for who issues can be (re)assigned to. of course, we could have a final entry at the bottom of the menu called "other" that was an autocomplete field, so that if for some reason it made sense to assign an issue to someone who was neither yourself, nor one of the maintainers of the project in question, you could still do that. not sure if what i just said would even be possible, or if this use-case would be worth spending time on. but, i think the idea of a group of maintainers-per-project is a good one, and would solve this problem pretty well. just a thought...

dww’s picture

Status: Needs work » Closed (duplicate)

nedjo recently bumped http://drupal.org/node/4354, which this issue is a duplicate of.
he's got a cool approach he's proposing to solve this, so let's move any further discussion there.