The arg() function is repeatedly called to determine the same argument value when building menu items. This should be changed to a single call, as in $arg0 = arg(0);

CommentFileSizeAuthor
#3 223481.patch2.04 KBezra-g
#1 223481.patch2.04 KBezra-g

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Needs review
StatusFileSize
new 223481.patch2.04 KB

Og_subgroups menu items seem to be working properly after applying this patch and clearing the menu cache. This patch also allows caching for the og_subgroups settings page and adds the $may_cache parameter to function definition of the og_subgroups_menu.

This is fairly straightforward and I intend to commit this shortly.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Fixed in 3.0.

ezra-g’s picture

ezra-g commented
StatusFileSize
new 223481.patch2.04 KB

Fixed in 5.x.3.0 with commit #103130 . Patch attached for reference.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.