Video without thumbnail displays weird

tdh - February 20, 2008 - 03:25
Project:Acidfree Albums
Version:5.x-1.x-dev
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Great module, ties in with drupal nicely and is not bloated. I have noticed something though. When viewing a user gallery, if a video does not have a thumbnail, it is displayed as a small 'play' button instead of something the size of the other image thumbnails. See attached screenshot to see what I am talking about. It would be nice if the play button was in a larger box the size of the image thumbnails.

AttachmentSize
acidfree_video.jpg14.07 KB

#1

tdh - February 20, 2008 - 03:37

I have also noticed that the random thumbnail for the cover of the album will sometimes show a white box with "Empty" when there is a video without a thumbnail in that album, even though there might be pictures also in that album. Maybe having an automatically created generic image thumbnail (that is not published) created when a video is submitted without a thumbnail would take care this problem and the problem above.

Thanks.

#2

vhmauery - February 22, 2008 - 16:44
Status:active» fixed

fixed in CVS.

#3

tdh - February 23, 2008 - 03:09

That fix took care of both of the above. Thanks! Great work! It shows a red X and says 'No thumbnail available.' Is this the intended behavior? Is there supposed to be a "nothumb.png" file under the art folder?

#4

tdh - February 23, 2008 - 06:21
Status:fixed» active

I created a file called "nothumb.png" and put it in the art folder, and that file shows on the thumb of videos without a thumbnail. So I assume that the "nothumb.png" file just needs to be added to CVS.

Thanks!

#5

tdh - February 24, 2008 - 20:22
Status:active» fixed

File "nothumb.png" is now included.

#6

tdh - February 24, 2008 - 22:24
Status:fixed» active

Maybe a better image than just a thumb would look nicer in the albums. I have attached a new image if you would like to add it to acidfree.

Thanks,

Todd

AttachmentSize
nothumb.png4.57 KB

#7

vhmauery - February 25, 2008 - 18:11
Status:active» fixed

What, you didn't like my thumb? Okay, so I have never been to graphic arts school. Let's just say my policy is that if I just add something that looks horrid, someone else is bound to come up with something better and offer it up. So thanks, you are just reinforcing my bad habits. :)

Anyway, I whipped up an SVG that looks similar to the PNG you posted. But what is cool is the code around it. Acidfree now automatically scales the SVG into a PNG to be the same size as the image thumbnails (for all those browsers that can't handle SVGs yet). If it can't do that (it uses 'exec("convert ...")' to do the conversion) then it falls back to a 100x75 PNG that is included with the distribution of Acidfree.

#8

vhmauery - March 5, 2008 - 05:43
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.