Trailing \n

Posted by therzog on February 20, 2008 at 6:03am

Issue Summary

Hi: I'm having a small problem due to the fact that the Markdown() function adds extra carriage returns to the end of its rendered output:

Line 201:
# Make sure $text ends with a couple of newlines:
$text .= "\n\n";

This causes CCK to interpret the field as non-empty, and it displays the field label with no field value.

I worked around it by just wrapping the _marksmarty_process in a trim function.

Posted by milianw on February 20, 2008 at 12:37pm

trim might not be a good idea, rtrim would be better. Take this markdown output for example:

    this is code
    this is code

rtrim would be finde, but trim would un-indent the first line.

An even better fix in my eyes would be to check for empty text in the process function:

<?php
function marksmarty_process($text, $format) {
  if (empty($text)) {
    return;
  }
  // ...
}
?>

Posted by moshe weitzman on February 20, 2008 at 6:08pm

Status:

active

» fixed

fixed this and moved include files

Posted by Anonymous (not verified) on March 5, 2008 at 6:12pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.