tac_lite port to Drupal 6

It will definitely happen. If anyone wants to take this on, please do and submit a patch.

If not, I'll get around to it eventually, but certainly not in the next two or three weeks.

I have updated this module (mainly due to the evolution of the 'form' api). Since I've discovered drupal recently, there are maybe some errors (in particular I have not changed the install file). But it works on my drupal installation.

I get this:

"Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of system_settings_form_submit(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /srv/www/htdocs/drupal6/sites/all/modules/tac_lite/tac_lite.module on line 117"
at the top of every single page on my test site.

In addition, "rebuild permission" doesn't work:

"An error has occurred.
Please continue to the error page
An error occurred. /drupal6/batch?id=11&op=do (no information available)."

I have changed something in the "_tac_lite_admin_settings_submit" function, should work now...
You will have to desactivate the module and reactivate in order to make it work (at least on my installation I have to do so!).

For the rebuild permission error, I don't know because this function is not part of the tac_lite module (function node_access_rebuild()).

I'm eager to take a look at this, but the next few days I'm very busy, so it will be the weekend before I install the patch. Just keeping you informed. And thanks so much for submitting it.

In the future please submit a proper patch rather than the entire module.

paulo_drop: Thank you for posting this!

However, I'm attempting to set up Role Based Privileges with this patch and it's not quite performing the way I expected it to.

The idea is to have separate roles be able to access separate private taxonomy terms. I have a taxonomy called "Privacy" which has two terms called "Private_A" and "Private_B." But when I assign specific roles access to specific terms under "Administer › User management › Access control by taxonomy › Role Based Privileges," it seems like when a role is assigned any of the "Privacy" terms, they have access to all "Privacy" terms.

Is this the way tac_lite is supposed to function? Or am I missing something??

Thanks!

You want to set up different taxonomies for different roles.

Iam should be able to allow different terms to different roles. There is no need to create more than one vocabulary.

Drupal's access rules are touchy. If your content type implements hook_access, and hook_access returns TRUE, then the node_access table will not be consulted. Either that, or there's a bug.

Its a good idea to install the devel_node_access module, which comes with devel. Enable the block it provides, then view one of the nodes in question. That will show you the node_access table entries for that particular node.

It's taken me a lot longer than expected to get to anything Drupal 6 related. Sorry for the slow progress on this.

I want to get patch http://drupal.org/node/248938 into Drupal 5 before creating a drupal 6 branch. If anyone can test that, it would be much appreciated.

Also Paulo, can you put together a proper patch of your changes? http://drupal.org/patch/create

That's the first time I create a patch, so I hope It will work. Tell me if there is any problem with this patch.

Just for what it's worth, I tried this version on a Drupal (6.2) site I'm working on, and it seems to work fine so far. Thanks!

The only odd thing I saw was that when I went to Administer-Modules, TAC_Lite showed up on the core list instead of on the contributed list. I installed it into sites/all/modules, correctly I believe, but this could well be my problem and I will investigate further.

Thanks again.

The place Tac_Lite shows up in the modules section doesn't depend on the path you stored it. It depends on the "tac_lite.info" file. Indeed it's not a core module, I have corrected it with this new patch...

Thanks very much, Paulo!

Works great. One Bug I could find. Regular users have a "tac_lite access" button in their My Account under "Edit". This is dangerous as a user should not be able to put themselves into a group. However, when you click on this link it goes to "Page not found", which is safer then the alternative. When you are logged in as an admin you can click on this button for a user and edit their memberships.

Thanks,
Adam

Hi,

Why not deliver a 6...dev version in order for many of us to test ?

Thank you.

Could this at least be available in HEAD? The version currently in HEAD does not describe what version of Drupal it's compatible with.

The very latest code is in the DRUPAL-5 branch. I'll do my best to update things later today.

After applying the other patch I mentioned earlier, this patch no longer applies. I don't have time to do any more tonight. If someone can re-roll the patch against HEAD that would be great. If not I'll try to get to it soon.

Be sure to run update.php after getting the latest tac_lite.

Also I'll try to fix the permission problem in #14 before checking in.

Thanks for your work on this Dave, look forward to giving it a test run at some stage.

Yes, big thanks here also... Excited to try it out!

Hi,

i have fixed the local task menu bug.

Original code in tac_lite.module:

Fixed code with correct 'access arguments' (see the two lines with the //***FIX*** comment):

Furthermore I suggest to include a 'weight' => 10 (some value > 1) field as well for not having the 'tac_lite access' tab (if it shows up) on the leftmost position in the local task bar (but this is a matter of taste).

Here, for the record, is the patch I am checking into HEAD. I haven't really tested it. That's why I'm leaving the issue open. If anyone can run it through it's paces, I'd be most grateful. No need to apply the patch, just use the latest from the HEAD branch, this is checked in.

From now on, in this thread, submit patches as a diff against HEAD.

Big thanks again to paulo_drop and everyone who's contributed.

Hi, I've just tried the HEAD version, and it seems to work very well, except for one bug:
If I give a user the right to administer tac_lite, acces to the tac_lite menu is still forbidden for this user.

However, thank you for the good work!

Hi. I'm relatively new to the project pages; where do I download the HEAD version for testing? Thanks

Dave have you forgot to include a HEAD version? The one on the project release page dates back to 2007:
Last updated: January 11, 2007 - 08:13

Please create a new release, and I look forward to testing this. Setting to CNW!

drupal.org will not build a head version for you, as far as I know. You have to check it out of CVS.
When I find time to fix the menu issue in #24 I'll create a DRUPAL-6 branch. But in the meantime any additional testing would be appreciated.

I'm really interested in this module but when I download the file above it says that its "Unable to extract the files and directories from the archive"
I'm using Net2FTP to upload it.
Any ideas why its not working? Or even better does somebody have another file that may work better?
Thanks!

I got this module to open and it works wonderfully.
I have not ran into any problems.
Thanks!

I found a little bug, I think: If you delete a node, the corresponding entry in "node_access" table won't be deleted. This is not critical, but nevertheless, it's quite useful to keep the table "smaller", more efficient & more actual. Adding this feature is quite easy: Just add a "hook_nodeapi" which reacts on deletion. Perhaps someone else could write this patch or I will write it in a few days, I think =)

That patch should not be necessary. The node module (core) should be doing that for us. Access control modules are no longer supposed to touch the node_access table directly. If this is happening, its a core bug.

Thanks for doing a great job on this module! I'm not familiar with diffs and such - are there any plans for the release date of a complete module for 6.x? :)

@pendlaren: The version in CVS works very well. The only issue is you can't make/change settings unless you're logged in as user id 1.

Apart from that, it seems fairly flawless, at least to myself.

I finally took the 6.x plunge and everything tac_lite is working as expected.

Cheers,
Tim

Hi there.

I'd be happy to test this code on D6, too. It would be awesome if someone knowledgeble could create a real 6.x-dev release. I've seen a few comments down this line from others asking for a test release, too.

I installed HEAD from CVS. When I enabled the module an error occured:

Line 48 is in menu_hook tac_lite_menu():

Clearing cache doesn't change anything (in fact this throws the same fatal arrow).

Cheers.

tac_lite is not the reason for this error, have a closer look at the error message:

Fatal error: Call to undefined function db_num_rows() in /home/www/drupal/sites/all/modules/community_tags/community_tags.module on line 48

So, the module "community_tags" is the one, perhaps it could be a conflict, but this is another thing.

Thanks for replying and sorry for messing that up.

I was diging on three modules at once which you shouldn't do ;) Anyway, now that you pointed it out I'm not sure anymore if I just copied the wrong error message or if indead there was no error at all with tac_lite... I'll come back if I get an error again.

Cheers.

I was able to put a build on the project page, but I don't know how to mark it as a development release, which is what it is.

I'll make an official Drupal 6 branch once we solve the permissions problems that are mentioned above.

Version currently is 6.x-0.0 and described as dev version. Shouldn't it be 6.x-dev instead then?

Cheers.

Exactly. I just don't have time to guess different CVS tags until I get it right. If anyone can tell me how to make it say that, I'll update it.

You have to create a new branch for this:
cvs tag -b DRUPAL-6--1
Then, a dev version will be shown in configuration.

Fixed (I think) the permission problem with the admin pages.

Created DRUPAL-6--1 branch and DRUPAL-6--1-2 release.

Thanks to everyone who helped!

Thanks so much Dave!

Sadly, the permissions problem doesn't seem to be fixed. (I'm using 6.x-1.2)

Logged in as God (User ID 1) I can edit the permissions/tac_lite options, but logged in as my normal power user (who has "administer_tac_lite" ticked) I'm still unable to and get a permission denied error.

I don't know enough about drupal to debug it I'm sorry.

Tim

What is the URL where you get permission denied?

Also, please try to empty cache (using the devel module) and see if it still is the case.

I'm really sorry, Dave, this does appear to be working correctly.

When I tried it this morning, it wasn't.

I can't figure out how to get Devel to display the block it used to have in 5.x, so I'm not sure how to clear the cache.

Regardless, it appears fixed. So I'm stupid.

Thanks!

on a side note devel 6 comes with a "development" menu block you have to enable/show in admin/build/block (and maybe enable the menu in admin/build/menu, not sure)

Update: Also using devel.module and it's user switch block switching to user/1 to change tac_lite settings is fairly easy.

Devel includes the lesser-known devel_node_access module which has a block useful for debugging node_access modules. Enable that block in your footer because it is wide.

Automatically closed -- issue fixed for two weeks with no activity.