First let me tell you that I'm very happy that you decided to continue development on acidfree!
On the issue: the title pretty much sums it up. I tried this with a 11MB .zip on Windows with a fresh Drupal 5.7 and Acidfree 5 from February 24th. Max file size and Max total file size are both 16M and I tried smaller files as well, no timeout happened. After submission the notice "Importing file tmp.zip" appears but nothing happens. Neither files/ nor files/images/temp contains the .zip or the extracted images. There is no further notice. The Zip extension is enabled:
Zip enabled
Extension Version $Id: php_zip.c,v 1.70 2006/08/14 15:54:34 pajoye Exp $

Another question: Do you recommend the usage of a specific Slideshow module? I tried Views Slideshow, which works, but isn't exactly what I was looking for. Would you include a slideshow view if I coded one? I'm thinking about a quite simple jQuery slideshow with pause/faster/slower.

Comments

scroogie’s picture

scroogie commented
Priority: Normal » Minor

I just saw that your using `unzip` with system().
I think there could be a fallback to use the Zip extension, although probably overkill, because every real server (besides testing setups like the one I used above) should have tar/unzip. But the check for false on the return value for system() is definitely missing. I wouldn't have issued the bug report if i had known the reason.
By the way, the amound of code in this module is awesome.

scroogie’s picture

scroogie commented
Assigned: Unassigned » scroogie
Category: bug » feature
Priority: Minor » Normal
Status: Active » Postponed (maintainer needs more info)

I have now patched my local copy of acidfree with a simple unzip using the built-in zip caps of php. If you are interested i can upload a patch, although there are some open questions.
How would you want the configuration to be implemented? The module could let the user choose what to use or just check if the functions for unzipping exist. The problem is that there has to be a check for each compression algorithm and additionally for php version (4 vs. 5). I currently have only php5 and zip, but i would also implement bzip and gzip if you are interested.
Just let me know.

vhmauery’s picture

vhmauery commented

The only problem with attaching this code to Acidfree is that it really is not Acidfree specific. Are there no other modules that just provide tools for other modules to use? That would be the kind of place I would put this code personally. I am sure a lot of people would like the idea of this since many people have to run in safe_mode or otherwise exec restricted modes. But unzipping files is not something that only Acidfree could benefit from. Do you see what I mean?

That said, I am not sure how to implement this as a module but then not depend on it for people like me who are just as happy to fork off a new process and unzip things that way. Ideally, we could implement this as a toolkit (like the image toolkit). Then the users could select what zip method to use.

scroogie’s picture

scroogie commented

Yeah, I see what you mean, it's a valid point you make there. There are indeed API-only modules, like ImageAPI, VotingAPI, MediaAPI or DrawingAPI just to name a few. The problem I see, however, is that most of these API modules are used by only one "real" module.
I'm not sure that many module devs would use such a "compression" module or what you would call it, because nobody likes additional dependencies. I will perhaps have a look at other issue queues to see if there is some basic interest. I guess there must be some people that use IIS on Windows as their production server (for some weird reason), or execute php in chroots without unzip or something. Let's see.

mwheinz’s picture

mwheinz commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)