I have found myself applying three patches time over time. I have therefore collected them in a single patch bundle for the convince of mine and others. The included patches are:

CommentFileSizeAuthor
#2 i18n.patch3.36 KBTBarregren
#1 i18n.patch1.93 KBTBarregren
i18n.patch1.94 KBTBarregren

Comments

TBarregren’s picture

TBarregren commented
StatusFileSize
new i18n.patch1.93 KB

Updated the patch according to the chang in #190414: I did some modification to deal with the duplicate url problem.

TBarregren’s picture

TBarregren commented
StatusFileSize
new i18n.patch3.36 KB

I have added #149108: Link to 'translate node' should change the site language to the patch bundle.

TBarregren’s picture

TBarregren commented
Status: Active » Needs review
bforchhammer’s picture

bforchhammer commented
drewish’s picture

drewish commented
Status: Needs review » Closed (duplicate)

this issue totally defeats the whole work flow of the issue queues: one task per issue. combining them makes it harder for the maintainer to review each one individually, harder to give proper credit on commit and divides feed back between multiple issues. please focus your efforts on the initial issues.

TBarregren’s picture

TBarregren commented

You are right strictly speaking.

My intention was of course not to make it harder for you to review the individual patches or give due credit where it belongs. I only wished to to provide a convenient bundle for everyone who like myself are dependent on applying these patches for a functional i18n site.

You may of course argue that everyone else should do as I did: download and apply the individual patches themselves. That is not hard, but it takes some time to work out the hunks that fails because the patches are made in isolation from all other patches. My idea by providing the patch bundle was just to save all other that labor. Think of it as a service for all users of the i18n module.

A possible solution that meets your concerns and still make it possible to provide a patch bundles, if necessary, would be to mark the patch bundle issue as duplicated on creation, and then just linking to it in the issues concerned.

jose reyero’s picture

jose reyero commented

Yeah, I think this is a good solution, having it marked as 'duplicate', so it doesn't add 'noise' to the issue queue.

I understand some people may find these patch bundle useful so nothing agains it being here.

About all these open issues, I'll be devoting some time this week to reviewing them, I'm afraid I've been too busy lately with the Drupal 6 version, but cleaning up the Drupal 5 issue queue is my next priority.

Thanks.

sinasalek’s picture

sinasalek commented

It's userful, thanks for sharing it.