Closed (duplicate)
Project:
Comment RSS
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Feb 2008 at 03:37 UTC
Updated:
23 Mar 2008 at 11:01 UTC
I ran the coder (code review) module and it guided me through some changes.
There are some remaining problems:
commentrss.module
* severity: normal Line 2: Include the CVS keyword $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ in each file. This should be in the format // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ or // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ (Drupal Docs)
// $Id: commentrss.module,v 1.12.2.2 2007/07/16 04:19:11 tangent Exp $
* severity: critical Line 35: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
if ($may_cache) {
* severity: critical Line 36: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
* severity: critical Line 44: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array('path' => 'crss', 'title' => '',
* severity: critical Line 166: Use menu_get_object() to get an object based on your path (Drupal Docs)
$vocab = taxonomy_vocabulary_load(arg(2));
commentrss.install
* severity: normal Line 2: Include the CVS keyword $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ in each file. This should be in the format // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ or // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ (Drupal Docs)
// $Id: commentrss.install,v 1.1.2.2 2007/07/16 04:20:06 tangent Exp $
| Comment | File | Size | Author |
|---|---|---|---|
| commentrss.diff | 6.13 KB | reikiman |
Comments
Comment #1
add1sun commentedDuplicate issue. Let's all work on the same patch please: http://drupal.org/node/215278