Hola,

Strange problem here, the 'Submit' button only on the modr8 queue page only appears to work for people visiting our site via Firefox; while the button does show for IE users, and has the little 'click' animation when clicked, nothing actually happens.

Any ideas?

Cheers,
Dinis

CommentFileSizeAuthor
#10 fivestar-5.x-1.11_modr8_form_teaser.patch555 bytesdavej
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Active » Postponed (maintainer needs more info)

odd- though this could be a core Forms API bug - what version of Drupal do you have running? Do other forms on your site work right in IE7? Is there another form on the same page as the modr8 form?

Dinis’s picture

Dinis CreditAttribution: Dinis commented

The site is running on Drupal 5.7 though this started a while ago (5.5 iirc). I've built a profile for testing with no blocks or forms visible or running etc. so the only button on the page is the Modr8 submit, and even then it's still the same.

It's the only page / button on the entire site I can find which has this odd bug too so It's quite a mystery tbh.

To be thorough, I've tried the same thing with Safari and it's fine on that browser too.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

Perhaps this is the same problem? http://drupal.org/node/189553

Dinis’s picture

Dinis CreditAttribution: Dinis commented

Interesting, they sound like identical symptoms with the only difference being I don't use Activeedit.

The submit button used to work perfectly, so maybe I'll try disabling mod by mod on my test server and see if the functionality returns at some point.

Dinis’s picture

Dinis CreditAttribution: Dinis commented

I've tracked down the conflicting module; it's with the 5 Star mod - http://drupal.org/project/fivestar

I'm unable to work out exactly why it's failing only on IE, but what ever it is, if Fivestar is enabled, the Modr8 submit button ceases to function.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Project: modr8 » Fivestar
Version: 5.x-2.3 » 5.x-1.x-dev
Component: User interface » Code

ok, well maybe Eaton can tell us if there is a conflicting form_alter or some such.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

Hi Dinis, that is indeed a strange symptom. Fivestar doesn't do anything with buttons on the page other than hide the ones for fivestar widgets, in which case they're not visible at all. Are there fivestar widgets being displayed on the page? Also check if jquery.rating.js is loaded on the page and if the form submits properly if javascript is disabled.

Dinis’s picture

Dinis CreditAttribution: Dinis commented

Howdy, thanks for the quick response.

I've tested as requested and can confirm that the Fivestar widgets display on the Modr8 submission page.

There is a temporary workaround in the Fivestar options in Content Types; Selecting the "hidden" option for teasers for any content which needs to be Modr8ed prevents the Fivestar widget from displaying on the Modr8 page.

Keep up the good work with these modules guys :)

davej’s picture

davej CreditAttribution: davej commented
Title: 'Submit' button not working in IE7 » Modr8 'Submit' button not working with Fivestar in IE7

When the teaser list at admin/content/modr8 contains Fivestar widgets, this means there are forms nested within the modr8 form. So I suspect that IE is being tripped up by this invalid HTML structure. If this is the cause then the solution involves not displaying Fivestar widgets in contexts where they are within an existing form.

davej’s picture

davej CreditAttribution: davej commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
fivestar-5.x-1.11_modr8_form_teaser.patch555 bytes

Luckily modr8 sets a flag on nodes displayed in modr8_form, so there's a simple fix to hide fivestar widgets in this form. Patch attached.

Dinis’s picture

Dinis CreditAttribution: Dinis commented

Many thanks,

I'm going with a new production build tonight so too late to make this one, but I'll add it to the test server on Monday (all going well over the weekend) and let you know how it works out.

Cheers again for the support and these terrific mods.

Danielle

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

I'll have to look - maybe modr8 itself should be making sure that $node->in_preview == TRUE

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

oh, wait - it's not in preview, it's a teaser.

Also, perhaps a broader fix would invovle changing the name of the modr8 submit button? How doe Fivestar decide which button(s) to hide?

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed

I believe davej was correct in his assessment. The forms inside of forms bug seems to be keeping IE7 from operating correctly. Even with JavaScript disabled the modr8 form still won't submit. Given the options, I think hiding the widget entirely is about as good as we can get. I've applied the patch in #10, slightly tweaked to use isset() so we can avoid unnecessary PHP notices.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

@quicksketch - maybe we need to think about a core patch? For example, we could at least suppress the building of an additional form if we are in the middle of a different form?

Dinis’s picture

Dinis CreditAttribution: Dinis commented

@pwolanin - This is something I would like to see too :)

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.