Hi,

I've just changed gallererix version on my site to 5.x-1.2
There is no possibility anymore to create content to gallerix nodes, and add comments to gallerix nodes created with the former version create php error.
Thanks for your help

Comments

silviogutierrez’s picture

silviogutierrez commented

You may not comment on albums since the pictures are the content, not the album.

However, if you want per picture commenting, take a look at the Gallerix Widget Engine.

Hope that helps,

Silvio

pgi’s picture

pgi commented

Hi Silvio,

First, thanks for your Gallerix Module, is perfect for uploading pictures into a Drupal Site.

I'm not sure to understand your response. Is it a bug in my site (for exemple the comment module that is doing wrong his job) or this feature is not present anymore into the Gallerix module ?
Because a per album comment is just perfect for what I need.

Thanks for your response

Pierre

silviogutierrez’s picture

silviogutierrez commented

Pierre,

This isn't a bug in your site, I turned off commenting to avoid strange behavior. This is because comments in Drupal use anchor tags (#) to mark their location, and Gallerix uses anchor tags to remember what picture is being viewed.

If you want to try commenting (at your own risk), try commenting the following code on line 898:

<?php
  //Regular comments need to be disabled in albums.
  if ($node->type == 'album') {
    unset($links['comment_add']);
    unset($links['comment_forbidden']);
  }
?>

However, I can't guarantee it'll work.

Silvio

pgi’s picture

pgi commented

Hi Silvio

I tried what you said, and I have error when I try to put a comment, but the comment is registred well. 



    * warning: Invalid argument supplied for foreach() in /home.50/t/r/o/tropspac/www/modules/node/node.module on line 521.
    * warning: implode() [function.implode]: Invalid arguments passed in /home.50/t/r/o/tropspac/www/modules/node/node.module on line 525.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /home.50/t/r/o/tropspac/www/includes/database.mysql.inc on line 172.
    * warning: Invalid argument supplied for foreach() in /home.50/t/r/o/tropspac/www/modules/node/node.module on line 521.
    * warning: implode() [function.implode]: Invalid arguments passed in /home.50/t/r/o/tropspac/www/modules/node/node.module on line 525.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /home.50/t/r/o/tropspac/www/includes/database.mysql.inc on line 172.

It seems to be an error in the node module : the function which populate a node

If you can help

Thanks for your answer

P.S.
The gallerix module doesn't work with the related content module (http://drupal.org/project/relatedcontent) when you attach more than one Gallerix node to another node : the pictures dont load. Do you know this issue? Is it necessary that I post a bug in the tracker?

pasa’s picture

pasa commented

Pierre ..

Did you leave comments activated and just ignore the logged errors? or did you find a workaround?

pgi’s picture

pgi commented

Hi,

I still got this problem. I found some kind of workaraund to put drupal's comments to album (not a single picture) but it's not perfect : I still have warning messages.

With the module "related content" (http://drupal.org/project/relatedcontent) I link a blog node with a gallerix node : the gallerix album appears with the blog node. Comments can be put for the node and will appear after the blog node and the gallerix album. BUT, I still got the warning message when the comments are published... The warning message disappear after.

I don't know what is the best solution : enable comments for gallerix albums or use the workaround with relatedcontent...

I don't think the gallerix widget is a good solution for this problem, because it doesn't use the drupal way for comments : cannot do the "latest comments" block for example...

Finally, I think the feature of comments for albums should be enabled in the core module of Gallerix.

Pierrot
(scuse my french :-) )

littledragon’s picture

littledragon commented
Version: 5.x-1.2 » 6.x-1.4

Otherwise, you can replace the lines by :

  // Regular comments need to be disabled in albums.
  if ($node->type == 'album') {
      unset($links['comment_add']['fragment']);
      unset($links['comment_forbidden']['fragment']);
    //unset($links['comment_add']);
    //unset($links['comment_forbidden']);
  }

No anchor, no problem ;-)

AlexisWilke’s picture

AlexisWilke commented

Adding a note here: I did turn the comments back on in the development version (6.x-1.x-dev).

I'll be changing the JS at some point to remove the use of the # to access an image. Instead, we can use the query string (which is already supported, but the JS changes it back to #). This will break some links, but that's a good fix for 2 reasons:

1) the comments will work as expected, and

2) the favicon will not disappear on FireFox, SeaMonkey.

Per picture commenting may be added if someone supplies a patch. See here: #929950: Comments for individual images

Thank you.
Alexis Wilke

AlexisWilke’s picture

AlexisWilke commented
Title: No comments for the gallerix nodes » Comments for the gallerix nodes cause a problem because of the # character
Version: 6.x-1.4 » 6.x-1.5

Changing the title so it reflects the need for the next step in 100% allowing comments in Gallerix nodes.