Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
Garland theme
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Mar 2008 at 11:13 UTC
Updated:
27 Mar 2008 at 20:21 UTC
Jump to comment: Most recent file
Attached patch fixes a couple of things, which are:
- Updates version numbers to reflect our current Drupal 7 development version (http://drupal.org/node/217926);
- Updates credits on top of the CSS files to reflect my website (i switched);
- Updates Garland CSS-files to close the long standing bug of non-resizable text in IE6 and IE7 (http://drupal.org/node/101629);
Please test and commit the patch...
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | garland-remove-headers.patch | 4.18 KB | Stefan Nagtegaal |
| #4 | garland-drupal-7-fixes.patch | 5.94 KB | Stefan Nagtegaal |
| #1 | garland-drupal-7-fixes.patch | 4.31 KB | Stefan Nagtegaal |
| garland-drupal-7-headers.patch | 3.63 KB | Stefan Nagtegaal |
Comments
Comment #1
Stefan Nagtegaal commentedNew patch, which:
- Updates version numbers to reflect our current Drupal 7 development version (http://drupal.org/node/217926);
- Updates credits on top of the CSS files to reflect my website (i switched);
- Updates Garland CSS-files to close the long standing bug of non-resizable text in IE6 and IE7 (http://drupal.org/node/101629);
- Updates Garland print CSS-file to print the page in a more comfortable way (readability: http://drupal.org/node/146029) ;
Please review and test the patch please. once this gets committed i'll close the other reports mentioned above..
@core committers: Only the latest patch is valid and should be tested/reviewed/committed..
Stefan
Comment #2
keith.smith commentedStefan: I'm curious -- why not remove the Drupal version from the comment header, rather than updating it with each new version? Does the Drupal version NEED to be in there, for ease in distinguishing changes from previous versions? The $Id$ tag is there, and it seems that would be sufficient.
One reason I ask is that I'm uncertain about the purpose of the header. IMO, it doesn't assert a specific copyright claim, nor a design credit, nor anything specific -- its just the two names, and apparently occurs only in the CSS files? The other core themes don't have a similar header in their .css files; if this is about noting the well-deserved design credit, then why not have just a single header in style.css or template.php (or some other file integral to the theme).
(Please note that I ask because I don't know the answer, not because I'm suggesting that you and Steven don't deserve tremendous credit for a fantastic theme.)
Comment #3
Stefan Nagtegaal commented@keith.smith: The header needs to stay where it is, also because of it is going to change in the future with a copyright notice that it may only be used in combination with drupal. We build the theme to be a specific drupal theme, and so I want it to be that way. I approach a couple of loyars to look into this if it is - at all - possible to accomplish this..
Further than that, I rather had seen that you really tested and reviewed the patch than started nitpicking on the headers.
Comment #4
Stefan Nagtegaal commentedNew patch, which:
- Updates version numbers to reflect our current Drupal 7 development version (http://drupal.org/node/217926, thanks dropcube);
- Updates credits on top of the CSS files to reflect my website (i switched);
- Updates Garland CSS-files to close the long standing bug of non-resizable text in IE6 and IE7 (http://drupal.org/node/101629, thanks Chill35);
- Updates Garland print CSS-file to print the page in a more comfortable way (readability: http://drupal.org/node/146029, thanks znikke) ;
- Updates info/error/normal messages consistent in terms of used margin/padding which results in a more consistent layout (http://drupal.org/node/216614, thanks Pancho);
- Updates the bullets in the menu to be more centered in front of it's text (http://drupal.org/node/216614, thanks Pancho);
Please review and test the patch please. once this gets committed i'll close the other reports mentioned above..
@core committers: Only the latest patch is valid and should be tested/reviewed/committed..
Stefan
Comment #5
scoutbaker commented@Stefan - I don't see the latest patch (#4). Thanks.
Comment #6
Stefan Nagtegaal commented@Scoutbaker: I added the patch in #4, good point! :-)
Comment #7
Freso commentedThe patch induce some minor(!) changes in the display on Firefox (namely the rendering of lists), but doesn't otherwise appear to change anything. I haven't tested the IE related stuff, as I don't have IE available. :)
Edit: It should probably be noted that the list rendering is intended, according to the issues this patch is out to fix/enhance, so the fact that their rendering changed, is due to the CSS-fu working.
Edit 2: For good measure, my Firefox == Mozilla/5.0 (X11; U; Linux i686 (x86_64); da; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12. I only have geckos available here, so I haven't bothered to test in another browser.
Comment #8
Stefan Nagtegaal commented@Freso: Yes, the changes in the lists are on purpose! The bullets are better vertical aligned in front of the text.
IE6/7 was tested by myself, also including Safri 2/3, and FF on Mac/Win.
This issue could use one more review to set this RTBC..
Comment #9
dries commentedStefan, I committed this patch to CVS HEAD but found it somewhat silly to include the 'for Drupal 7' as well as the copyright headers. We don't do this for other code either. I would accept a patch that removes those for sake of consistency, and that adds you to the MAINTAINERS.txt.
Comment #10
Stefan Nagtegaal commented@Dries: I'll make a patch for that!
Thanks for reviewing/committing though..
Comment #11
Stefan Nagtegaal commentedDries, as you requested..
I removed all the headers from the stylesheets and added myself as a maintainer in the MAINTAINERS.txt file.
Comment #12
JohnForsythe commented"a copyright notice that it may only be used in combination with drupal"
This seems like a bad precedent and counter to the spirit of open source. If we start locking out others from using Drupal resources, they will surely do the same to us. Imagine no more Wordpress theme ports, for example. We need to maintain open sharing with other projects, otherwise we are no better than, say, Microsoft.
Comment #13
Stefan Nagtegaal commented@johnForsythe: Yes, I know that and I agree...
Comment #14
droshani commentedThanks for the hard work,
But how do you actually make use of this patch? How do you implement it? Any dummy step-by-step please :(
Please note that one major issue with this Theme is the Slogan of the site which appear oddly in the same size as the title and in front of it. It could be nice to have the Slogan beneath the title and much smaller/italic text instead
I use Durpal 6.x, is the patch for 6.x version
http://drupal.org/node/226943
Comment #15
keith.smith commentedkoyauni: See http://drupal.org/patch/apply for more information about applying patches.
Comment #16
droshani commentedthank you, but I host web site on a Hosting server, I am not sure how to use the patch file on the server side. Why do not they create a new Theme package so users can replace the whole theme?
Comment #17
dries commentedCommitted to CVS HEAD. Thanks.
Comment #18
michellekoyauni - This issue is for fixes to a core theme for Drupal 7.x. If you want to patch your copy, you were given instructions. There won't be a separate release of the theme as this theme is part of Drupal core, not contrib.
Michelle
Comment #19
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.