Closed (fixed)
Project:
Services
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
7 Mar 2008 at 16:24 UTC
Updated:
12 Apr 2008 at 17:19 UTC
Jump to comment: Most recent file
This patch is an addition to views_service.module which adds an interface to the views import and export functionality. One use of this would be for deploying views between servers without having to get into the code base. It might also be useful for verifying that the version of a view on two servers are the same. It adds two new services:
- views.importView
- views.exportView
I wrote this as part of my server staging and deployment project (http://drupal.org/project/deploy)
Let me know if you have any questions or whatnot.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | views_service.patch | 3.41 KB | gdd |
| #2 | views_service.patch | 3.4 KB | gdd |
| views_service.patch | 3.17 KB | gdd |
Comments
Comment #1
wim leers- null => NULL
- // Comments like this.
-
/**
* Doxygen like this.
*/
Otherwise looks good.
Comment #2
gddPatch re-rolled. It is slightly over-topic now because I did the following:
- fixed comment style throughout the module, not just in my additions.
- changed "$view == NULL" to "is_null($view)" throughout the module, not just in my additions. This is the proper way to check for NULL.
Thanks for the review.
Comment #3
wim leersOne more minor thing:
+ // _views_save_view will treat this as an insert rather thanshould be
+ // _views_save_view() will treat this as an insert rather thanP.S.: I didn't know about is_null(). Thanks!
Comment #4
gddRerolled.
Comment #5
wim leersCoding style: perfect. Now you'll need somebody to test this.
Comment #6
moshe weitzman commentedI tested this and it worked. It is committable as is. We really do need standardized return values from callbacks. This only returns a vid upon successful deployment. Thats not quite enough to feel good about.
Comment #7
marcingy commentedCommitted to D5 and D6
Comment #8
marcingy commented