Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
ping.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Mar 2008 at 22:35 UTC
Updated:
4 Apr 2008 at 15:42 UTC
Jump to comment: Most recent file
Comments
Comment #1
catchSee also:
http://drupal.org/project/multiping
Comment #2
robloachI'm 100% up for this. The attached patch might do it. I'm not too sure how removing directories works with CVS.
Comment #3
keith.smith commentedHmm. I'm all for this.
There's a mention of ping module in a user-facing description in system.module, though, along with a mention in INSTALL.txt, and seems like this would be CHANGELOG.txt worthy.
Comment #4
catchHere's a re-roll with those taken out and a CHANGELOG.txt entry.
Comment #5
Freso commentedHere's a patch that actually goes the extra mile of removing modules/ping/*. It can't remove the directory itself though... but then, directories can't be deleted from CVS (which is why you're using
update -P- to prune empty directories from the working repository).Comment #6
keith.smith commentedOut of curiosity, is this a situation like drupal.module? That is, is there another recommended alternative already in contrib or will a volunteer be recruited to check the current ping.module into contrib under a new name?
Comment #7
Susurrus commented@keith.smith: Catch suggested the MultiPing module as a related module. At a quick glance it looks like this module covers everything that the ping module did, and more...
Comment #8
robloachI put a note in the Multiping issue queue about keeping Multiping up to date with Drupal core releases so that people who use the Ping module can move to Multiping.
Comment #9
moshe weitzman commentedapplies cleanly and does the job.
Comment #10
dries commentedWow, you guys are fast to remove stuff. ;-) I've committed this patch to CVS HEAD. Thanks all.
Comment #11
Susurrus commentedPing.module should also be removed as a component of the Drupal project.
Comment #12
Freso commentedPeople still need to be able to file bugs against D5's ping.module.
(Also, drupal.module is still listed as a component. I don't know the reasoning behind this, but it makes sense to me to keep old components, as long as the old versions which do have the components are also listed.)
Comment #13
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.