Remove ping module from core
catch - March 7, 2008 - 22:35
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | ping.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
It's only tiny, but it's a bit crufty. Marking as needs review because I don't know of a way to remove a folder via a patch. Comments and RTBCs welcome.
#1
See also:
http://drupal.org/project/multiping
#2
I'm 100% up for this. The attached patch might do it. I'm not too sure how removing directories works with CVS.
#3
Hmm. I'm all for this.
There's a mention of ping module in a user-facing description in system.module, though, along with a mention in INSTALL.txt, and seems like this would be CHANGELOG.txt worthy.
#4
Here's a re-roll with those taken out and a CHANGELOG.txt entry.
#5
Here's a patch that actually goes the extra mile of removing modules/ping/*. It can't remove the directory itself though... but then, directories can't be deleted from CVS (which is why you're using
update -P- to prune empty directories from the working repository).#6
Out of curiosity, is this a situation like drupal.module? That is, is there another recommended alternative already in contrib or will a volunteer be recruited to check the current ping.module into contrib under a new name?
#7
@keith.smith: Catch suggested the MultiPing module as a related module. At a quick glance it looks like this module covers everything that the ping module did, and more...
#8
I put a note in the Multiping issue queue about keeping Multiping up to date with Drupal core releases so that people who use the Ping module can move to Multiping.
#9
applies cleanly and does the job.
#10
Wow, you guys are fast to remove stuff. ;-) I've committed this patch to CVS HEAD. Thanks all.
#11
Ping.module should also be removed as a component of the Drupal project.
#12
People still need to be able to file bugs against D5's ping.module.
(Also, drupal.module is still listed as a component. I don't know the reasoning behind this, but it makes sense to me to keep old components, as long as the old versions which do have the components are also listed.)
#13
Automatically closed -- issue fixed for two weeks with no activity.