Download & Extend
Issues

Remove ping module from core

Posted by catch on March 7, 2008 at 10:35pm
Project:Drupal core
Version:7.x-dev
Component:ping.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

It's only tiny, but it's a bit crufty. Marking as needs review because I don't know of a way to remove a folder via a patch. Comments and RTBCs welcome.

Login or register to post comments

Comments

#1

Posted by catch on March 7, 2008 at 10:59pm

See also:
http://drupal.org/project/multiping

#2

Posted by Rob Loach on March 7, 2008 at 11:06pm

I'm 100% up for this. The attached patch might do it. I'm not too sure how removing directories works with CVS.

AttachmentSizeStatusTest resultOperations
remove_ping.patch2.95 KBIgnored: Check issue status.NoneNone

#3

Posted by keith.smith on March 7, 2008 at 11:27pm
Status:needs review» needs work

Hmm. I'm all for this.

There's a mention of ping module in a user-facing description in system.module, though, along with a mention in INSTALL.txt, and seems like this would be CHANGELOG.txt worthy.

#4

Posted by catch on March 8, 2008 at 6:47pm
Status:needs work» needs review

Here's a re-roll with those taken out and a CHANGELOG.txt entry.

AttachmentSizeStatusTest resultOperations
removemoreping.patch5.37 KBIgnored: Check issue status.NoneNone

#5

Posted by Freso on March 9, 2008 at 11:45pm

Here's a patch that actually goes the extra mile of removing modules/ping/*. It can't remove the directory itself though... but then, directories can't be deleted from CVS (which is why you're using update -P - to prune empty directories from the working repository).

AttachmentSizeStatusTest resultOperations
removeevenmoreping.patch8.28 KBIgnored: Check issue status.NoneNone

#6

Posted by keith.smith on March 9, 2008 at 11:49pm

Out of curiosity, is this a situation like drupal.module? That is, is there another recommended alternative already in contrib or will a volunteer be recruited to check the current ping.module into contrib under a new name?

#7

Posted by Susurrus on March 10, 2008 at 3:50am

@keith.smith: Catch suggested the MultiPing module as a related module. At a quick glance it looks like this module covers everything that the ping module did, and more...

#8

Posted by Rob Loach on March 10, 2008 at 3:49pm

I put a note in the Multiping issue queue about keeping Multiping up to date with Drupal core releases so that people who use the Ping module can move to Multiping.

#9

Posted by moshe weitzman on March 10, 2008 at 8:32pm
Status:needs review» reviewed & tested by the community

applies cleanly and does the job.

#10

Posted by Dries on March 11, 2008 at 8:12am
Status:reviewed & tested by the community» fixed

Wow, you guys are fast to remove stuff. ;-) I've committed this patch to CVS HEAD. Thanks all.

#11

Posted by Susurrus on March 18, 2008 at 2:37pm
Status:fixed» active

Ping.module should also be removed as a component of the Drupal project.

#12

Posted by Freso on March 21, 2008 at 3:41pm
Status:active» fixed

People still need to be able to file bugs against D5's ping.module.

(Also, drupal.module is still listed as a component. I don't know the reasoning behind this, but it makes sense to me to keep old components, as long as the old versions which do have the components are also listed.)

#13

Posted by Anonymous (not verified) on April 4, 2008 at 3:42pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here