Closed (fixed)
Project:
Date
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Mar 2008 at 20:26 UTC
Updated:
20 Feb 2012 at 03:10 UTC
Jump to comment: Most recent file
Hi!
There is a new string "Empty 'To date' values will use the 'From date' values" under the second row of selectboxes ("date - to") on date field.
But this text is there always visible, doesn't matter if I set for value for "to field" to "blank", "same as from", etc.
I attached a screenshot
Please note that (besides that what I wrote is a bug) I can't find sense of this text, what is difference between let comboboxes empties, or with values same as from field? both options do same result - "same as from".
thanks
Igorik
http://www.somvprahe.sk
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | To_Date_help_text-232954-10.patch | 845 bytes | arlinsandbulte |
| #8 | date-help-text-232954-8.patch | 732 bytes | rho_ |
| #4 | date-help-text-232954-4.patch | 732 bytes | rho_ |
| text.gif | 12.61 KB | igorik |
Comments
Comment #1
karens commentedEmpty 'To date' values are always filled with the 'From date'. Displaying them as blank values is just an option to make the selector less distracting, internally they work the same (and have always worked that way in previous versions of the Date module).
The new text is to help the end user realize that if they want a 'To date' that is exactly the same as the 'From date' except for one value (like the time) that they don't have to select every single part of the 'To date', just the part that should change. This is a new feature to make input easier, and that text is always displayed by design, as a helper.
If once this is in use people find it confusing, we can adapt, but for now we're going to try it this way.
Comment #2
igorik commentedHi
I can see the main missunderstood of it when I set in content type for date "to" field, date "same as from" and this text
"Empty 'To date' values will use the 'From date' values"
is still under it. It makes no sense IMHO and it is missunderstood for users who want to select date for event.
igorik
http://www.somvprahe.sk
Comment #3
tstackhouse commentedI don't mean to dig up an old issue, but I am encountering this exact same issue, the text is highly ambiguous and confusing to my users. I have configured the field to use Now as oposoped to the From date, but this text still persists and is not easily removed.
Comment #4
rho_ commentedDoesn't look like there's been much movement here, but ran into this "issue" today.
Our team too found this text to be ambiguous, and in certain instances plain wrong. The present default behavior is to append the "Empty 'To date' values will use the 'From date' values" to any user submitted help text. I have changed this behavior to have only the user submitted text display, unless empty in which case the default text will remain. I'm not sure that this is preferred behavior for the module (likely not), but thought I would throw a patch up to maybe help begin a conversation.
EDIT: I should note this patch was rolled on the current 6.x-dev version of date
Comment #6
rho_ commented#4: date-help-text-232954-4.patch queued for re-testing.
Comment #8
rho_ commentedI think the patch was failing because of the specified version, updating issue to 6.x-dev and reapplying.
Apologies for the testing spam.
Comment #9
rho_ commentedComment #10
arlinsandbulte commentedDate module patch testing is not working for the 6.x branch right now, so don't bother.
It is working for the 7.x branch, which is why we have left it enabled.
And, actually, this statement IS true regardless of the "To Date's" default value. Empty parts WILL be populated with the same value as the "From Date."
But, if you wish to override this text and provide your own, I can understand that. Please review updated patch. I added a feature that will completely eliminate the help text if you just put some white space in the Help text field. So it works as follows:
Please review attached patch.
Comment #11
rho_ commentedAfter looking at this again, yes indeed the default text it true in all cases. Apologies for misspeaking.
I have applied the patch in #10 to a fresh Drupal 6.23-dev installation using Date 6.x-2.8+9-dev and it has worked like a charm. I have run through all three bullet points and each work as specified. Thanks for the reply and reworking the patch arlinsandbulte!
Comment #12
arlinsandbulte commentedCommitted #10 with a small change (we don't need to concatenate):
http://drupalcode.org/project/date.git/commit/fb0fe66