[D7] Flux Pocket

please include the git clone command in the issue

I also found some issues using pareveiw here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxgleek2282655git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Command that you mentioned is incorrect. Correct command to clone the code would be

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/gleek/2282655.git flux_pocket

Hi Umar,

Thanks for contributing, Below is my feedback:

Automated review still showing lots of errors:

http://pareview.sh/pareview/httpgitdrupalorgsandboxgleek2282655git

Git clone command that you mentioned above doesn't seem to be correct one.

git clone --branch 7.x-1.x gleek@git.drupal.org:sandbox/gleek/2282655.git flux_pocket

can you please check it.

Automated Review

No.
http://pareview.sh/pareview/httpgitdrupalorgsandboxgleek2282655git
Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a

lot, then post a link to the automated review and mention that problems should be addressed.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and fragmentation.

Master Branch

Yes/No: Follows the guidelines for master branch.

Licensing

No. LICENSE.txt is there inisde the code.: Follows the licensing requirements

3rd party code

No. Third party files are placed inside module.: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the

href="https://www.drupal.org/node/2181737">README Template

.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Not sure. Need to test this module on some Vanilla Drupal installation. If "no", list security issues identified.

Coding style & Drupal API usage

1. (*) Major finding. Just try to download this module through git clone and try to enable it using Drush. Getting following error:
   

   [root@bangvmplccpc01 modules]# git clone --branch 7.x-1.x http://git.drupal.org/sandbox/gleek/2282655.git flux_pocket
   Initialized empty Git repository in /var/www/html/permission/sites/all/modules/flux_pocket/.git/
   remote: Counting objects: 485, done.
   remote: Compressing objects: 100% (266/266), done.
   remote: Total 485 (delta 238), reused 313 (delta 139)
   Receiving objects: 100% (485/485), 73.36 KiB | 57 KiB/s, done.
   Resolving deltas: 100% (238/238), done.
   [root@bangvmplccpc01 modules]# drush en fluxpocket
   No release history was found for the requested project (rules_scheduler).                                                                                    [warning]
   The following projects have unmet dependencies:                                                                                                              [ok]
   fluxpocket requires fluxservice
   Would you like to download them? (y/n): y
   Project fluxservice (7.x-1.0-rc1) downloaded to sites/all/modules/fluxservice.                                                                               [success]
   Project fluxservice contains 2 modules: fluxservice_user, fluxservice.
   No release history was found for the requested project (rules_scheduler).                                                                                    [warning]
   The following projects have unmet dependencies:                                                                                                              [ok]
   fluxpocket requires xautoload, composer_manager, uuid
   Would you like to download them? (y/n): y
   Project xautoload (7.x-5.0) downloaded to sites/all/modules/xautoload.                                                                                       [success]
   Project composer_manager (7.x-1.6) downloaded to sites/all/modules/composer_manager.                                                                         [success]
   Project uuid (7.x-1.0-alpha5) downloaded to sites/all/modules/uuid.                                                                                          [success]
   Project uuid contains 5 modules: uuid_default_entities_example, uuid_path, uuid_services, uuid_services_example, uuid.
   No release history was found for the requested project (rules_scheduler).                                                                                    [warning]
   Module fluxpocket cannot be enabled because it depends on the following modules which could not be found: rules_scheduler                                    [error]

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are

important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are

recommendations.

Thanks for contributing, Below is my feedback:

Automated review

PAreview is still showing lots of errors, check the below links :
http://pareview.sh/pareview/httpgitdrupalorgsandboxgleek2282655git.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and fragmentation.

Master Branch

Yes/No: Follows the guidelines for master branch.

Licensing

No. LICENSE.txt is there inisde the code.: Follows the licensing requirements

3rd party code

No. Third party files are placed inside module.: Follows the guidelines for 3rd party code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Not sure. Need to test this module on some Vanilla Drupal installation. If "no", list security issues identified.

Coding style & Drupal API usage

Please correct the above error, then go through the @PA robot 's #7 comment above.

Follow the guidelines at Review Bonus to get your project reviewed.

The automated review is not a blocker, please do a real manual review.

Please see automated report and fix errors
http://pareview.sh/pareview/httpgitdrupalorgsandboxivinco1197408git

manual review

there are no implementation of hook_help()

As I know this was a successful GSoC project mentored by derhasi, so I'm sure that the code is fine.

However, here my review:

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Coding style & Drupal API usage

1. If possible use "fluxpocket" as module name (not "flux_pocket"), as all integration modules until now are named this way.
2. The usage instructions in USAGE.md are really good, there is only a small typo in the last line: "require seperarate fluxservices".

I tested this module using latest version of the fluxkraft distribution. Installation worked as intended, including the composer-manager update to download the third-party library. I authenticated my pocket account and added a test rule that created an entity when I saved a new url using pocket. Worked like a charme. Great job!

I really would like to see this module having a full release!

This review uses the Project Application Review Template.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.