This module has a ton of Coding standards violations. Please use the Coder module.

CommentFileSizeAuthor
#3 vocabindex-diff-coder.patch40.54 KBdeekayen

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: Unassigned » xano

Last month I have edited the local working copy and practically all the code complies with the coding standards. The only thing that needs some work is indenting as my current editor doesn't support spaces for indenting.

By the way: which status does an issue need to have when the local copy has been fixed, but if the fix simply hasn't been committed yet?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Unless you supply a patch or commit a fix, it should remain "active." Occasionally I will use "patch (to be ported)" as an indicator to myself that it is yet to be committed. That makes it a different color in the issue queue.

deekayen’s picture

deekayen commented
Status: Active » Needs review
StatusFileSize
new vocabindex-diff-coder.patch40.54 KB

There are many other things other than tabs.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Active

Thanks for the effort, but the local working copy has become totally different from the latest dev version in CVS by now, so I'm afraid the patch won't work at all. I'm still working to clean up the code and get the latest bits for term index pages and index blocks ready. After that I'll commit the new version. Won't take more than one or two weeks I guess.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Fixed and committed to 6.x-2.x-dev.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned