Coding standards violations
NancyDru - March 13, 2008 - 12:30
| Project: | Vocabulary Index |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Xano |
| Status: | closed |
Description
This module has a ton of Coding standards violations. Please use the Coder module.
#1
Last month I have edited the local working copy and practically all the code complies with the coding standards. The only thing that needs some work is indenting as my current editor doesn't support spaces for indenting.
By the way: which status does an issue need to have when the local copy has been fixed, but if the fix simply hasn't been committed yet?
#2
Unless you supply a patch or commit a fix, it should remain "active." Occasionally I will use "patch (to be ported)" as an indicator to myself that it is yet to be committed. That makes it a different color in the issue queue.
#3
There are many other things other than tabs.
#4
Thanks for the effort, but the local working copy has become totally different from the latest dev version in CVS by now, so I'm afraid the patch won't work at all. I'm still working to clean up the code and get the latest bits for term index pages and index blocks ready. After that I'll commit the new version. Won't take more than one or two weeks I guess.
#5
Fixed and committed to 6.x-2.x-dev.
#6
#7
Automatically closed -- issue fixed for two weeks with no activity.