version for Drupal 6
tomaszx - March 17, 2008 - 17:50
| Project: | Read More Tweak |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Thanks for this module :)
| Attachment | Size |
|---|---|
| ed_readmore.module.patch | 11.89 KB |
| ed_readmore.info_.patch | 526 bytes |
| ed_readmore-6.x-1.2-tomaszx.tar_.gz | 8.09 KB |
#1
I used your patch (actually, I skipped the patch part and just downloaded your tar.gz file).
The tweak seems to work perfectly fine, as it did before I moved to drupal 6. The only issues I see are that the >> after "Read More" are doubled, so it says "Read More >> >>". Also, the space before the word "read" is part of the link.
Purely cosmetic stuff. Other than that, works great! Thanks!
#2
I dont see what is wrong. Please look on my screenshots.
On translations it is ok, and on english too.
#3
#4
Ah. Yeah. I went through the settings. The text was set to "read more >>" instead of just "read more". So, the module was doubling the >> part. My mistake.
Thanks for the patch! Works perfectly then.
#5
enjoy :)
Could you add this to repository? i dont have access to CVS.
Thanks.
#6
Unfortunately, I don't either.
#7
This version work and is complete. Use and enjoy.
#8
I'm working on committing this to CVS for Drupal 6. Thanks for the patch, and thanks for your patience.
#9
I've committed my modifications to the original patches under the DRUPAL-6--2 branch and the DRUPAL-6--2-0-BETA1 tag. I hope I've created the CVS branches and tags correctly... if so, we should begin seeing it show up under nightly dev builds.
I found a problem in the .info file that prevented the module name from showing up on my Drupal 6.2 installation, and, I decided to remove the hard-coded leading and trailing spaces and the trailing » because not everyone is going to want that in their "Read more" link - which is why it wasn't in the code in the first place; you had to embed it in the string in the configuration page or add them to your theme's css. I removed the leading and trailing non-breaking-spaces for the same reason, because that's a styling issue, and one can easily add margin/spacing information to style.css (span.read-more) if you don't want to embed it in the configuration string. Nitpicking, perhaps, but that's how I feel about it :D -- I'm sure there are better solutions but this is a simple module and I think it's wise to keep things simple.
In any case, thanks a bunch to tomaszx for the initial port and thanks to all for your patience. (BTW, I must note that many important modules have not really been ported to D6 .... what's up with that? I see lots of comments from people who have rolled sites with D6 only to regret the decision to become early adopters...)
#10
Automatically closed -- issue fixed for two weeks with no activity.