Comments

kooseefoo’s picture

Status: Needs review » Needs work

I used your patch (actually, I skipped the patch part and just downloaded your tar.gz file).

The tweak seems to work perfectly fine, as it did before I moved to drupal 6. The only issues I see are that the >> after "Read More" are doubled, so it says "Read More >> >>". Also, the space before the word "read" is part of the link.

Purely cosmetic stuff. Other than that, works great! Thanks!

tomaszx’s picture

StatusFileSize
new29.36 KB
new33.61 KB

I dont see what is wrong. Please look on my screenshots.
On translations it is ok, and on english too.

tomaszx’s picture

Status: Needs work » Needs review
kooseefoo’s picture

Ah. Yeah. I went through the settings. The text was set to "read more >>" instead of just "read more". So, the module was doubling the >> part. My mistake.

Thanks for the patch! Works perfectly then.

tomaszx’s picture

Status: Needs review » Reviewed & tested by the community

enjoy :)

Could you add this to repository? i dont have access to CVS.

Thanks.

kooseefoo’s picture

Unfortunately, I don't either.

tomaszx’s picture

Title: This is my patch to Drupal 6 for your code » version for Drupal 6

This version work and is complete. Use and enjoy.

mcurry’s picture

I'm working on committing this to CVS for Drupal 6. Thanks for the patch, and thanks for your patience.

mcurry’s picture

Status: Reviewed & tested by the community » Fixed

I've committed my modifications to the original patches under the DRUPAL-6--2 branch and the DRUPAL-6--2-0-BETA1 tag. I hope I've created the CVS branches and tags correctly... if so, we should begin seeing it show up under nightly dev builds.

I found a problem in the .info file that prevented the module name from showing up on my Drupal 6.2 installation, and, I decided to remove the hard-coded leading and trailing spaces and the trailing » because not everyone is going to want that in their "Read more" link - which is why it wasn't in the code in the first place; you had to embed it in the string in the configuration page or add them to your theme's css. I removed the leading and trailing non-breaking-spaces for the same reason, because that's a styling issue, and one can easily add margin/spacing information to style.css (span.read-more) if you don't want to embed it in the configuration string. Nitpicking, perhaps, but that's how I feel about it :D -- I'm sure there are better solutions but this is a simple module and I think it's wise to keep things simple.

In any case, thanks a bunch to tomaszx for the initial port and thanks to all for your patience. (BTW, I must note that many important modules have not really been ported to D6 .... what's up with that? I see lots of comments from people who have rolled sites with D6 only to regret the decision to become early adopters...)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

mroswell’s picture

Status: Closed (fixed) » Active

Can there be an official release made of this?

dddave’s picture

Yes, that should be done. Please.

The time spent since the last dev is enourmous. If not for the surge to make it into D7 this looks almost abandoned on first sight......

choster’s picture

Status: Active » Fixed

Looks like 6.x-4.0 is out.

mcurry’s picture

Indeed it is.

dave reid’s picture

Not sure why we needed a whole new 4.x branch when just simply a 3.0 tagged release could have been made...

mcurry’s picture

I've created a 3.0 tag, and deprecated the bogus 4.0 tag. Please use the 3.0 release.

I apologize for the confusion caused by my inability to suss out Drupal's tagging conventions and CVS commands.

mcurry’s picture

Version: 5.x-1.2 » 6.x-3.0
Status: Fixed » Closed (fixed)
priceline’s picture

Hi,
I have downloaded this module, and enabled. but i am not seeing the readmore link at the end of teaser view?
is there any link which explains how to steps?
Thanks

todd nienkerk’s picture

@priceline: Please create a new issue if you want to file a support request. By commenting on an old, closed issue, you're making yourself hard to find!

To create a new issue, go to the Read More module's main issues page and click the Create a new issue link in the upper left.