I've downloaded and installed the latest version today. I find the admin screen messed up quite a bit:

1. "Show only users where" section seems to be composed from 3 columns (too narrow, what I've managed to resolve through CSS), what makes those items vertically not to be aligned (textareas are much higher than the rest...). Besides, the usage is a bit confusing, as a user has to select one of the items from the left column and to fill the corresponding field in the corresponding right column (which now are not in line). Wouldn't it be better to somehow generate the right part only for the selected left column item? Or, to have all left and right column items available (with checkboxes on the left instead), the middle (logic) items for all lines and with selectable AND / OR logic between the checked lines?

2. Users table display contains all of the columns from the user profile (more than 20 of them in my case), and there is no theory this to fit into the screen decently. This way, the table widens the browser window (which gets the scrollbar), but is in my case expanded to the right behind the right pane (maybe a problem of my theme only, but even without that it is not nice...). In any case, it would probably be better to have this table "trapped" into the window available for such display (with a horizontal scrollbar for this table only, and not for the whole browser), and - more important - a user to have an option to skip some columns from the display.

I hope I managed to describe my problems (and suggestions) in an understandable way.

CommentFileSizeAuthor
#10 advuser.5.x-2.x-dev.patch4 KBAnonymous (not verified)
#8 advuser.5.x-2.x-dev.patch4 KBAnonymous (not verified)
#6 advuser.5.x-2.x-dev.patch4.06 KBAnonymous (not verified)

Comments

Anonymous’s picture

My concentration for the moment is the actual functioning of the filtering and operations but do note that the display has issues. If you or anyone else feels they can make a patch to correct the display issues I would be more than happy to give it a go. Otherwise the display resolution will remain to be an issue for some time.

As for the theme, I am currently testing with the default garland theme which seems to work but with a few quarks once in a while. The UI may present differently dependent on which browser is used as well. I also wonder if the class and id names are correct; I plan to look at those, eventually.

Anonymous’s picture

Status: Active » Postponed (maintainer needs more info)

Is this still an issue? Is it there related?

luti’s picture

It is still an issue, as much as I see it. I believe it would be better to put fields in the table, so they would be better aligned - but, I am afraid to mess with the code so much for the moment...

Anonymous’s picture

What theme are you using?

luti’s picture

Generally my own, slightly adapted Garland. But, it is the same problem with (unmodified) Garland theme.

I am not sure if we understand each other well... I mean, how is it possible to achieve the alignment of items positioned in 3 columns and over 15 rows (with many different heights) without simply putting items in a table? And, which theme could enable a display of over 20 columns on even 24" screen (would be approx. 70 px per column only) in an acceptable way... Or, how? ;-)

Anonymous’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new4.06 KB

I've reworked the filter options into a table instead of a definition list. I hope it helps. Let me know what you think.

luti’s picture

thanks for your effort, earnie.

The first (upper) part of the screen looks much better now. It would be perfect, but I've noticed 2 problems:


  1. I have 2 select fields in my user profile. While there is no problem with non-profile select fields (as "Permission", "Status" and "Role" - they are displayed and work well in your module), both relevant table cells - where those 2 selects from user profile should appear - are empty. I've checked the HTML code of the page displayed, here is a copy of one such row (as you can see, there is nothing in the cell where a select field should be displayed):
    <tr>
    <td>
    </td>
    <td class="a">
    <div class="form-item">
    <label class="option">
      <input name="filter" value="profile_gender" class="form-radio" type="radio">
    Gender
    </label>
    </div>
    </td>
    <td>
    </td>
    <td class="b">
    </td>
    </tr>
    

    The code in users properties (for the same field; probably there should be more or less the same...) is:

    <label for="edit-profile-gender">
    Gender: 
    </label>
    <select name="profile_gender" class="form-select" id="edit-profile-gender">
      <option value="0">
    --
      </option>
      <option value="male">
    male
      </option>
      <option value="female">
    female
      </option>
    </select>
    


  2. Resizable textareas have a strange look - there is an unresizable textarea (as in users properties, where this field is not resizable) and "something" below of it on the left side (grey, looks like a letter "I" - maybe it is just a very narrow grey border, but it looks strange as it is detached from the field and only as wide as left border of the textarea above). At this location, the cursor changes shape, and it is possible to resize the field above (during resize, the whole textarea border turns into grey, and they are partially overlapping; after resize, textarea border turns back into black, but they remain approx. 50% overlapped).
    <tr>
    <td>
    </td>
    <td class="a">
    <div class="form-item">
    <label class="option">
      <input name="filter" value="profile_add_info" class="form-radio" type="radio">
    Additional info
    </label>
    </div>
    </td>
    <td>
    </td>
    <td class="b">
    <div class="form-item">
    <div class="resizable-textarea">
    <span>
    <textarea cols="60" rows="5" name="profile_add_info" id="edit-profile-add-info" class="form-textarea resizable processed">
    </textarea>
    <div style="margin-right: -396px;" class="grippie">
    </div>
    </span>
    </div>
    </div>
    </td>
    </tr>
    

    A code of some other resizable textarea (which looks "normally" - a textarea with a wider grey bottom border, through which you can resize the field) is:

    <label for="edit-explanation">
    Explanation:
    </label>
    <div class="resizable-textarea">
    <span>
    <textarea cols="60" rows="5" name="explanation" id="edit-explanation" class="form-textarea resizable processed">
    Put some additional info here.
    </textarea>
    <div style="margin-right: -4px;" class="grippie">
    </div>
    </span>
    

    I have TinyMCE module installed, but it is not in use in those (admin) screens (settings of TinyMCE).

In any case, it seems to me something in this module doesn't just pick some types of fields, but somehow converts them. Other fields seem to be just fine.

About the second part of my post, I can live with my theme settings, even if it would be much better to have something as "Window -> Freeze" in OpenOffice Calc (or, M$ Excel) - meaning the first column and row to be fixed (always visible). The same for pager below of this table, which is now initially displayed at the center bottom, but easily slips to the left when scrolling to the more right columns...

Anonymous’s picture

StatusFileSize
new4 KB

Syncing the patch with CVS. The resizing grippie class isn't being applied to resizable class which is the issue you notice. I'll have to chase down why before committing to CVS.

luti’s picture

I can confirm the issue #1 from my previous post (#7) is resolved with the latest development version (from May 15th) and the latest patch applied.

Thank you, earnie.

Anonymous’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new4 KB

One last issue is a concatenation white space issue. The attached redo patch fixes that issue. This patch is ready for commit.

Anonymous’s picture

Status: Reviewed & tested by the community » Fixed

Patch committed to CVS.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.