Posted by dsp6855 on March 24, 2008 at 4:55pm
| Project: | Admin Menu Hider |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Are there plans to update this for Drupal 6?
Comments
#1
This module depends on Drupal Administration Menu. For further information about admin_menu's port to D6 and how you can help, see http://drupal.org/node/132524
#2
Patch rolled against HEAD.
Works perfectly on my config, can someone else confirm.
On a side note, I also cleaned up the code so it conforms to the Drupal coding standards.
#3
Looks good, code-wise.
Heh... if you want to get nitpicky on coding standards, you need to
- add a comma after last values in arrays spanning multiple lines.
- add a trailing dot/punctuation for the description in the .info file.
- remove double-quotes from .info file values as long as they're not required.
- replace multiple calls to drupal_get_path() with one $path variable.
- remove hook_menu() and add AMD's settings to DAM's settings form.
- add a newline to the end of file, so diff stops complaining.
...however, all of these points may or may not come later ;)
#4
I've gone ahead and applied the patch for the new 6.x-1.x branch after some testing. Apologies for taking so long to get this done. My life has been consumed by too many projects as of late. Deciphered is now a co-maintainer of this module so hopefully future updates for this module will be applied more quickly :)
#5
#6
This patch is actually incomplete. I can't roll a patch atm, but the .info needs the dependency to be an array:
i.e.:
dependencies[] = admin_menuFurther, this seems to preserve the bug in the .css where you need more specificity on the second selector... it should be body.admin-menu, not just body.
Other than that, I have it running on my D6 test site.
#7
The patch is irrelevant, the port has been complete and is available as 6.x-1.x-dev.
While what you have stated is correct and is still an issue in the dev build, if you would like to report it, start a new issue, if not, it will be fixed as soon as I get home from work.
#8
Automatically closed -- issue fixed for two weeks with no activity.