Valid CSS

I'm also interested in solution of this Issue

Yea please move the hacks to a conditional css file and just get rid of the first 2 errors

I don't think that the 3rd error is a problem because it is not an error but css3

I am trying to start a web design company and want my site to have valid css! since I am using that as a selling point :) {dont want to be a css hypocrite} ha ha

Ps

Thick box rocks

THANKS soooo much :)

Hi– Thanks for these posts... but... 2 Qs:

1. Which hacks – can you post which styles should go in the IE6 conditional stylesheet?

2. And – has anyone found a solution for the remaining errors in psynaptic's first comment above?

Thanks in advance–
:) Scott

A separate thickbox_fix-ie.css with conditional comments would be good. The problem is how to add it automatically from a module. You can't use the standard drupal_add_css().

I guess you could insert it with drupal_set_html_head() but that feels a bit crud.

What do you think?

I know it's a holiday in the us, but just thinking this is kinda important for others besides myself

also... going out on a limb here... perhaps the priority mi8 be higher than 'minor'?

:) Scott

I found some suggestions: http://matteogallinucci.it/web/2008-02-04/thickbox-css-code-validation-f...

But I agree with scottrigby, priority should be higher than minor...

I found a solution to fix the css errors that seems to work perfectly, just follow these steps

1. Download the plugin here: http://www.contezero.net/sites/contezero/index.php/2008/12/14/thickbox-fix-plugin/

2. Upload the files within the zip file to your thickbox module folder (note: this will replace the thickbox.css file in the module folder so make sure you back it up before uploading)

3. add the following line to your thickbox.module file at the end of the _thickbox_doheader() function: drupal_add_js($path .'/tb_css_fix.js'); // fixes css errors

function _thickbox_doheader() {
  ...
  if (variable_get('thickbox_auto', 0) && module_exists('image')) {
    drupal_add_js(array('thickbox' => array('derivative' => variable_get('thickbox_derivative', 'preview'))), 'setting');
    drupal_add_js($path .'/thickbox_auto.js');
  }

  drupal_add_js($path .'/thickbox.js');
  drupal_add_js($path .'/tb_css_fix.js'); // fixes css errors
}

That's it

I've tested this in ie6/7 and Firefox and it works fine, also I'm using version 6 of Drupal so I'm not sure if this fix will work in version 5 but I see no reason why it shouldn't.

Works like a charm on the Toronto Yoga Guide site. Thanks, Vivian!

Works like a charm on the Toronto Yoga Guide site. Thanks, Vivian!

Thanks for your contribution! But could you tell us for which Thickbox version this patch was produced?

I'm using thickbox 6.x-1.2 and applied your patch. Now there's a javascript error in Firefox's error console:

Error: TB_HEIGHT is not defined
Source File: http://localhost/sites/all/modules/thickbox/tb_css_fix.js?4
Line: 52

The error goes away if I insert the line below at the start of thickbox.js:

var TB_HEIGHT;

... but I'm not sure if this is the right solution.

Also, a CSS error appears when I open a thickbox image:

Warning: Error in parsing value for property 'margin-top'.  Declaration dropped.
Source File: http://localhost/pt-br/empinando_fotografias
Line: 0

On the Internet Explorer, now there is the following error:

Line: 53
Char: 13
Error: Invalid argument.
Code: 0
URL: http://localhost/pt-br/empinando_fotografias

Any suggestions to fix these problems?

Thickbox for Drupal 6 has now a separate CSS file for Internet Explorer.

Could the IE stylesheet be made conditional?

whoops, sorry about the .info fuzz.

Hi there,

I am using THICKBOX in 6.x-1.5 with Drupal 6.15 .... When I checked the CSS Code of a new Website, the W3C CSS Validator found 13 errors - all because of the css files in the Thickbox Module ... will this be fixed?

i.e.: CSS Validation Check

As I mentioned in #14 Thickbox now have a separate CSS files for IE fixes. Check "Do not include special CSS for Internet Explorer" in the Thickbox settings (admin/settings/thickbox) if you want to.

This will of course remove support for Internet Explorer.

The validator will continue to complain about the Firefox specific "-moz-opacity" but that I don't see as a problem.

Would you mind reviewing the patch in #17? It places the stylesheet in a conditional comment so it only loads on IE. This method is consistent with Drupal core, for example Garland puts fix-ie.css in a conditional comment.

subscribing