April wasn't soon enough. ;)

We at pingVision needed thickbox for a D6 project we're working on, so I've upgraded the module. I've attached a patch that modifies the following files: thickbox.info, thickbox.module, and thickbox_auto.js.

I've tested the settings page, the image module integration, thickbox functionality on individual images, and thickbox login. I haven't tested it for multiple images yet, but I suspect they'll work just fine.

I hope this provides you with a good start toward getting a D6 release out there.

CommentFileSizeAuthor
#3 thickbox-d6-v3.patch6.7 KBgribnif
#1 thickbox-d6-v2.patch6.71 KBgregnostic
thickbox-d6.patch6.4 KBgregnostic

Comments

gregnostic’s picture

gregnostic commented
StatusFileSize
new thickbox-d6-v2.patch6.71 KB

Seems as though I missed a selector that needed to be updated for the latest version of jQuery. A new version of the patch is attached.

cyberswat’s picture

cyberswat commented
Status: Needs review » Reviewed & tested by the community

Any chance of getting this patch applied and into a d6 dev branch? It's looking good from here.

gribnif’s picture

gribnif commented
StatusFileSize
new thickbox-d6-v3.patch6.7 KB

One minor, suggested change: According to the D6 upgrade docs at http://drupal.org/node/103114, you should not continue to wrap title and description strings in hook_menu() in the t() function.

Here's the patched patch.

gregnostic’s picture

gregnostic commented

Good catch. That's an easy one to overlook when you spend most of your day in D5 code.

frjo’s picture

frjo commented
Version: 5.x-1.1 » master
Assigned: Unassigned » frjo

Thank you very much for this patch. I will test it and then commit it to cvs as soon as I can. April has been kind of hectic but is should calm down a bit soon.

frjo’s picture

frjo commented
Version: master » 6.x-1.x-dev
Category: feature » task
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Committed to 6-dev, should show up shortly and if you are in a hurry you can always get it via cvs.

Please test it out and report back here.

jwilde’s picture

jwilde commented

Hi Guys,

Thanks for the upgrade. User/login is not working on 6.2. The popup displays but it is empty - no login form. I haven't tried any other features yet.

Best Jim

joncup’s picture

joncup commented

Same here. Blank login popup. Just wanted to post so I could follow this more closely, this is my favorite feature of this module, wish the registration and password forms were handled too.

Should we file this as under a new issue?

farald’s picture

farald commented

dumdidum.. *tapping fingers in anxiety*

joncup’s picture

joncup commented

@hamaldus the lightbox module now supports login links, if this module works for you maybe we should mark this issue as postponed

frjo’s picture

frjo commented

Please try out the just committed 6-dev version to se if login links work now. It should show up shortly and if you are in a hurry you can always get it via cvs.

Please notice that I have changed the thickbox login links from "example.com/thickbox_login?..." to "example.com/user/login/thickbox?...". This is how Lightbox does it and I thought it looked better. What do you think?

I have also added some small hacks to thickbox.js that I have been using on my own site for some time:

* The next and previous images preloads so that users dont have to wait when clicking through a image gallery.
* There is now a small fade in effect when Thickbox opens.

Do these hacks work for you? Are they good to include?

frjo’s picture

frjo commented
Status: Postponed (maintainer needs more info) » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.