Update from taxonomy_image 5.x-1.0 to 5.x.1.1 causes errors

Very strange indeed. TI does not access the term_node table at all and does nothing that I know of that would cause a module (like access control) to alter the queries. We don't even use db_rewrite_sql to allow such modules to stick their fingers in. This query looks like it has been modified by an access control module (TAC, TAC_Lite, Node Access, etc.). And it looks like it's accessing a node; TI does not do node access of any kind.

I'm guessing you have some other module that is accessing nodes (perhaps just the front page query in node.module) that is also invoking Taxonomy Image. If you can identify which one it is, I'll be happy to work with the owner of that module to find out why this is happening. But I doubt it is Taxonomy Image at fault.

I know there are other people using 5.x-1.1 beside myself, so this problem surprises me. I'd like to get a handle on it so it can be fixed.

I've alerted the person who contributed this code since I am not a Views heavy-weight.

Basically, taxonomy_image_views_tables is the function that adds view support for taxonomy_image:

This function returns data that will describe how your module's tables relate to the Drupal node table, as well as what fields can be displayed and sorted, and how your tables may be filtered. This hook can return just one or many tables.

You can read more about it here:
http://drupal.org/handbook/modules/views/api

and more specifically (fields, as that is all the function adds):
http://drupal.org/node/99565

The error appears to be showing that it's not using your prefix table, "dp5_" though (in term_node.name.) The table function just tells views module what to query, it doesn't actually do the querying itself. I wonder if the calling function (in views) forgot a {} in the query, or maybe the format for the fields has changed in the table array?

In looking a my term_node table, I don't see a "name" field anyway, though, so maybe it's something else.

I'm afraid I don't have the time to troubleshoot this issue further, right now, but hopefully this will help you get started.

I could be wrong (I think I'd have to really take a closer look at that bit) but I think that is what connects the taxonomy_image reference to the node, so it seems kind of essential to the views working correctly.

Do the views work as expected with that bit taken out (correct taxonomy images attached to the right nodes)?

I'm guessing you mean this part (in taxonomy_image_views_tables):

  $tables['term_node'] = array(
    'name' => 'term_node',
    'join' => array(
      'left' => array(
        'table' => 'node',
        'field' => 'nid'
      ),
      'right' => array(
        'field' => 'nid'
      )
    ),
  );

If I remember correctly, I needed to add both of these to get the JOIN working correctly, but if testing shows that it's not needed (and actually causes problems) then we should totally take it out, or figure out a better way to handle it.

Does it work ok without the taxonomy term in the view? I am thinking now that may have been my motivation (I think of myself as a good code-commenter, but I can't tell what that bit was for either.) If it does, then I am all for removing it. If not, maybe a conditional in there would help things.

That's not what I mean.

What I mean is this:
The code in question applies a JOIN on Taxonomy data to link Taxonomy Images with nodes. The reason it is conflicting is that Taxonomy does the same thing. Removing it may make it work when you have taxonomy in another view field (becuase it handles the join for the view), but I'm guessing that it will not work if there is no other taxonomy fields in the view.

I ask for others to test, because as I said, I'm really swamped right now. When I get a little more time, I'd be happy to check it out.

I can confirm what Uwe reports.

I'm having trouble setting up a view that does what Konsumer suggests.

Are we saying, then, that it is correct to remove $tables['term_node'] and that the module will still function correctly?

Well, that's simple enough to fix. I would like to have Konsumer or Brenda003 confirm this, as they are more Views-savvy than I.

Related: http://drupal.org/node/244644 - According to that user, this does not work.

Some more information:

* After uninstalling the Taxonomy Image module (and before installing the latest version), I noticed that the Taxonomy:All terms filter still wasn't there.

@pawshaker - then this module can hardly be blamed. Perhaps a support issue against Views is in order.

Hi Nancy, that's where this thread was originally posted?

I just moved your other thread back to Views with additional information. Since I am not well liked in the Views world, I suggest you ride with it.

ANY change that involves Views means you need to clear the cache.

Hi,

I have exactly the same problem. My Taxonomy:All terms filters are gone. Especially with the popular_content views.
With a "normal" view I got it back, but on popular_content it didn't work. Do I need to do something any where else with the $tables['term_node']?
I have updated taxonomy image to version 1.2, emptied my cache, but I do not see the filter "Taxonomy:All terms" any more!
Please assist. Thanks in advance for going into this.

EDIT: I can confirm that commenting out:

function taxonomy_image_views_tables() {
  //$tables['term_node'] = array(
  //  'name' => 'term_node',
  //  'join' => array(
  //    'left' => array(
  //      'table' => 'node',
  //      'field' => 'nid'
  //    ),
  //    'right' => array(
  //      'field' => 'nid'
  //    )
  //  ),
  //);

Is working! I do not know the influence of this on the taxonomy_image module, but my site is giving the correct info now again.
Thanks a lot for this thread!
greetings,
Martijn

greetings,
Martijn

Thank you, Martijn. Can you confirm or deny the concern in #12? There is an issue against Views mentioned in #18; you may want to add your two cents worth on that issue.

Hi,
I have more than one view, and they are al working now again. I do not know if there is a taxonomy relation in all the views sorry.
Anyone else can confirm Nancy here concerns are correctly interpreted with this commenting out $tables['term_node']?
Greetings,
Martijn

I don't have time to test but removing the term_node should do it - that was done by me before I understand views very well. I believe any reports of this not working are caching issues.

Thanks, Brenda.

I have commented out that table and committed this to -dev on both branches.