Hi,

If you set a custom Flickr user ID, for example for the Flickr recent photos block, that user ID isn't used by the code in the block because of a typo.

Basically the line :

    if (isset($settings['user_id'])) {
      $settings['user_id'] = variable_get('flickr_default_userid', '');
    }

should (of course) be :

    if (!isset($settings['user_id'])) {
      $settings['user_id'] = variable_get('flickr_default_userid', '');
    }

I added a small patch which fixes this (against the CVS head version)

Thanks for the nice module!

CommentFileSizeAuthor
flick-block-userid-6.x.patch671 bytesgdevlugt

Comments

drewish’s picture

drewish commented
Status: Needs review » Reviewed & tested by the community

looks good to me.

drewish’s picture

drewish commented
Status: Reviewed & tested by the community » Fixed

thanks, committed to HEAD.

buffalo2wheeler’s picture

buffalo2wheeler commented

Does "committed to HEAD" mean that the flickr module I downloaded and installed today (4 days after the patch above was reviewed) is included in the module's code, or do I need to apply the patch myself?

Thanks,
Thomas

drewish’s picture

drewish commented

i think the -dev builds are re-built every night. it's probably good to go but you should probably grab the -alpha1 release.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.