need db abstraction

schuyler1d - March 31, 2008 - 19:00
Project:Outline Designer
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

to support DB prefixes, etc. style should be '{node_type}' instead of 'node_type' and good practice is not to use the '.' string concatenation in db strings but instead %s/%d use. In D6, this is required, but no reason not to here.

(PS, as promised at drupalcon, I said I'd review your work, and submit patches issues. here i am :-)

AttachmentSize
db_abstraction.patch2.11 KB

#1

btopro - April 1, 2008 - 04:12

I'll test 'er out tomorrow though I'm sure this'll be fine. Thanks for the review, these comments are exactly the kinda things I need to clean this stuff up for the masses. I'll implement it tomorrow.

#2

btopro - April 1, 2008 - 13:48
Status:active» fixed

thanks for the patch, went back through and applied this issue to my ajax code too

#3

Anonymous (not verified) - April 15, 2008 - 13:51
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.