to support DB prefixes, etc. style should be '{node_type}' instead of 'node_type' and good practice is not to use the '.' string concatenation in db strings but instead %s/%d use. In D6, this is required, but no reason not to here.

(PS, as promised at drupalcon, I said I'd review your work, and submit patches issues. here i am :-)

CommentFileSizeAuthor
db_abstraction.patch2.11 KBschuyler1d

Comments

btopro’s picture

I'll test 'er out tomorrow though I'm sure this'll be fine. Thanks for the review, these comments are exactly the kinda things I need to clean this stuff up for the masses. I'll implement it tomorrow.

btopro’s picture

Status: Active » Fixed

thanks for the patch, went back through and applied this issue to my ajax code too

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.