Posted by samirnassar on April 1, 2008 at 4:03pm
Jump to:
| Project: | Multiping |
| Version: | 5.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
This cleans up Coding Standards as well as cleaning up the use of db_query() with LIMIT in favor of db_query_range().
| Attachment | Size |
|---|---|
| multiping-coding-standards-SP20080401-unified.patch | 15.82 KB |
Comments
#1
Can't test this patch as I only have D6 Multiping at the moment.
Our first priority is to get a D6 version up and running and fully released. I could download the D5 module and see if there is anything useful in this patch, but is it worth it? For the time-being shall we leave the V5 code as-is?
Jonathan
#2
With Drupal 7 coming up I think that both it and Drupal 6 should be of higher priority than Drupal 5.
I think that:
Version 6.x should be priority one.
Version 7.x should be priority two.
Version 5.x should see no new development - only critical bug fixes.
Marking this as postponed?
#3
I downloaded the v5 version (not to install though) and checked the results of the patch, just to make sure there was nothing which we want to take forward into D6. Apart from lots of code layout improvements for standards (which are already covered in the new V6 patch) there are only two substantive changes. The first changes db_query to db_query_range in install and this is not used at all in V6. The second change actually introduces a bug because it add extra { } around the $from in the sql selects, reported in #334351: Error in SQL-Queries. This probably due to the original poster using coder which falsely suggests this.
So marking this as wont fix, because we are only doing vital security and critical bug fixes to V5.
Jonathan
#4