Feeds/Read more links have invalid urls

NikLP - April 1, 2008 - 18:05
Project:Panels
Version:5.x-2.0-beta2
Component:Views panes
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Under Panels 2.x beta 2 (and dev at 1/Apr/08), I have a panel. In this panel, I have created two panes (it's a two column layout) and in each of these is an embedded view.

The issue here is, these views both have "read more" links, and feeds. To be fair, now that I have sorted out the paging inside the panel, the read more link is less important, but still a "should have". The feed is positively required. Both these features appear to work, but the urls that are listed with them are incorrect.

In both cases, if my view is called "/blog", the link appears as "/blog/*", and this is not a valid URL. Clicking this takes the browser to "/blog/%2A" which basically breaks the view.

#1

sdboyer - April 15, 2008 - 18:21

We're aware of this issue, and it remains an issue in beta3. It's on the list to be fixed for beta4, if nobody beats me to it with a patch.

Is there some reason you're not using beta3?

#2

NikLP - April 16, 2008 - 00:17

No I haven't fixed it, and I don't think after all that we're using the latest version but that's not fixed right now.

#3

capellic - April 17, 2008 - 13:13

I am having the same problem. I was hoping to create an argument on the view to the effect of:

view/1

where 1 is the page, but I see that the forward slash will be escaped, too.

And yes, this module is AMAZING!

#4

NikLP - April 18, 2008 - 11:57

That's a nonsense, you can't put slashes in arguments. If you mean "1 is the node id" then you need to read this: http://drupal.org/node/206185

#5

cirotix - May 6, 2008 - 09:05
Status:active» patch (code needs review)

This was an easy catch, here is the patch

AttachmentSize
panels_views_argument.patch496 bytes

#6

NikLP - May 6, 2008 - 12:01

This appears to work, (you beautiful human being).

#7

sdboyer - May 6, 2008 - 13:42

This was an easy catch...

LOL - I'm glad you think so :) I'd been back and forth through the this code but for some reason read RIGHT past that typo. This isn't quite the end of it, unfortunately, as there are still some extraneous feed icons being rendered, but that's pretty superficial. This most certainly does appear to take care of the major problem.

Patch has been committed, and it'll be fixed as of beta4.

#8

sdboyer - May 6, 2008 - 13:43
Status:patch (code needs review)» fixed

#9

Anonymous (not verified) - May 20, 2008 - 13:55
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.