I get these PHP notices, ordered by row number, when running a patched version of img_assist on Drupal 6 (the patch is unrelated to the notices):
notice: Undefined index: #suffix in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 158.
notice: Undefined variable: output in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 711.
notice: Undefined index: width in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1125.
notice: Undefined index: key in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1163.
notice: Undefined variable: regen in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1177.
notice: Undefined variable: output in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1711.
I suppose those should be fixed once we've updated to 6 and after that we should also port those changes to Drupal 5.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | img_assist-241527-080629.patch | 2.82 KB | zoo33 |
| #1 | img_assist-DRUPAL-5.phpnotices.patch | 3.4 KB | sun |
| #1 | img_assist-DRUPAL-6--1.phpnotices.patch | 2.55 KB | sun |
Comments
Comment #1
sunPatch for D5 includes a change in theme_img_assist_textarea_link() to be consistent with D6.
Comment #2
zoo33 commentedAnother one:
I'll keep adding them here if I find more. Will review and/or update patch later.
Comment #3
zoo33 commentedYour changes look good. I made two additional changes on rows 242 and 246. If those are good – then RTBC.
Comment #4
sunGreat! Committed.
Comment #5
zoo33 commentedLet's port this to 5.x based on the patch in #1 and the last one.
Comment #6
zoo33 commentedOh, just saw you did that already... Great!
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.