PHP notices
zoo33 - April 1, 2008 - 22:18
| Project: | Image Assist |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
I get these PHP notices, ordered by row number, when running a patched version of img_assist on Drupal 6 (the patch is unrelated to the notices):
notice: Undefined index: #suffix in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 158.
notice: Undefined variable: output in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 711.
notice: Undefined index: width in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1125.
notice: Undefined index: key in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1163.
notice: Undefined variable: regen in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1177.
notice: Undefined variable: output in /Users/hannes/Documents/workspace/img_assist-5/img_assist.module on line 1711.I suppose those should be fixed once we've updated to 6 and after that we should also port those changes to Drupal 5.
#1
Patch for D5 includes a change in theme_img_assist_textarea_link() to be consistent with D6.
#2
Another one:
notice: Undefined variable: voc in /Users/hannes/Documents/workspace/img_assist-6/img_assist.module on line 246.I'll keep adding them here if I find more. Will review and/or update patch later.
#3
Your changes look good. I made two additional changes on rows 242 and 246. If those are good – then RTBC.
#4
Great! Committed.
#5
Let's port this to 5.x based on the patch in #1 and the last one.
#6
Oh, just saw you did that already... Great!
#7
Automatically closed -- issue fixed for two weeks with no activity.