translate node references with i18nsync [#242601]

this is a patch that allow to synchronize nodereference fields with the corresponding translations (if they exists).
info about patched module:

; $Id: i18nsync.info,v 1.1.2.3 2007/06/18 23:06:46 dww Exp $
name = Synchronization
description = Synchronizes content translations
dependencies = i18n translation
package = Multilanguage - i18n - experimental
; Information added by drupal.org packaging script on 2007-10-30
version = "5.x-2.2"
project = "i18n"
datestamp = "1193766006"

patch:

--- i18nsync.module.orig	2007-06-06 13:54:18.000000000 +0200
+++ i18nsync.module	2008-04-04 13:08:46.000000000 +0200
@@ -163,16 +163,46 @@ function i18nsync_node_translation($node
           }
         }
         break;
-      default: // For fields that don't need special handling
-        if (isset($node->$field)) {
-          $translation->$field = $node->$field;
-        }
+      default: // For other fields
+       if (isset($node->$field) && $_field = $node->$field) {
+         // For nodereference fields !IT'S RAW METHOD, MAY NEED REVIEW!
+         if (isset($_field[0]['nid']) && $_field[0]['nid'] != $node->nid ) {
+           i18nsync_node_translation_referenced_node(&$node, &$translation, $field);
+         } else {
+           // For fields that don't need special handling
+           $translation->$field = $node->$field;
+         }
+       }
     }
   }
   node_save($translation);
 }
 
 /**
+ * Node reference that may have translation
+ *
+ */
+function i18nsync_node_translation_referenced_node(&$node, &$translation, $field) {
+$translation->$field = array();
+  $_field = $node->$field;
+  foreach ($_field as $key=>$reference) {
+    if ($referenced = node_load($reference['nid'])) {
+      // This content type has translations, find the one
+      if (variable_get("i18n_node_$referenced->type", 0) && isset($referenced->translation[$translation->language])) {
+        array_push($translation->$field, array('nid'=>$referenced->translation[$translation->language]->nid));
+        drupal_set_message(t('%title referenced node has been synchronized to %language translation',array('%title'=>$referenced->title, '%language'=>$translation->language)));
+      } else {
+        // Reference without translation, just copy the nid
+        array_push($translation->$field, $_field[$key]);
+      }
+    } else {
+      // False reference nid, just copy the nid
+      array_push($translation->$field, $_field[$key]);
+    }
+  }
+}
+
+/**
  * Node attachments that may have translation
  * 
  */

I also give in attached files a bundled patch of this add-on + "automatic update path after synchronizing taxonomy" (see http://drupal.org/node/237546#comment-779300)

Tests and reviews are welcome!

Comment	File	Size	Author
#4	i18n-242601-4.patch	3.75 KB	dasjo
#3	i18n-242601-3.patch	3.09 KB	dasjo
	i18nsync.pathauto_nodereference.patch	3.67 KB	adrien.gibrat
	i18nsync.nodereference.patch	1.98 KB	adrien.gibrat

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Jose Reyero CreditAttribution: Jose Reyero commented 28 April 2008 at 10:35

Status:

Needs review

» Needs work

This looks good. However I think we could reuse the code for attached nodes which is quite similar.

Also, to avoid future headaches, it should handle the case of cck fields with multiple values.

Comment #3

dasjo

he/him

German

Zurich

CreditAttribution: dasjo commented 21 May 2009 at 03:57

Title:	Try to translate node reference with i18nsync	» translate node references with i18nsync
Version:	6.x-1.0-beta4	» 6.x-1.x-dev
Component:	Experimental modules	» Code
Priority:	Critical	» Normal
Status:	Needs work	» Needs review

File	Size
i18n-242601-3.patch	3.09 KB

nedjo and me worked on a solution for this issue regarding the translation of nodereferences in i18n, drupal 6

jose, so we followed your advice, reused the attached nodes sync code.

so we have a helper function i18nsync_node_translation_reference_field which is used by i18nsync_node_translation_attached_node and i18nsync_node_translation_nodereference_field

i attached the patch, it's actually my first one, so i hope it works fine ;)

File	Size
i18n-242601-4.patch	3.75 KB

Comment #5

Jose Reyero CreditAttribution: Jose Reyero commented 12 June 2009 at 12:54

This one looks much better

Just need someone else to give it a try and tell me it works.

@nedjo, if you are around, feel free to commit.

Comment #6

Jose Reyero CreditAttribution: Jose Reyero commented 12 June 2009 at 13:11

Status:

Needs review

» Fixed

I'm thinking let's speed up the process.

As I've been committing some other improvements in that module, see changelog, I've also committed this one, so you don't need to update it again.

If this breaks anything, someone will let us know :-)

Comment #7

26 June 2009 at 13:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #8

Dubs CreditAttribution: Dubs commented 7 July 2009 at 08:02

We have a CCK Node reference which referencing bi-lingual versions of a node. If we have a view which uses the node reference field as an exposed filter, then select a node and change language, then we get the following error: -

An illegal choice has been detected. Please contact the site administrator.

You can see the problem at http://plwm.nmaltd.com/events/gallery

Just pick an event from the dropdown (the node reference field) and then click "Cymraeg) in the top-right and the error should be displayed.

Is there anything that i18n can do about this, or does the problem lie outside the scope of this module?

Comment #9

GN CreditAttribution: GN commented 9 August 2009 at 13:27

Status:

Closed (fixed)

» Active

i18nsynching of nodereferences seems to work only for already existing nodes, not for a fresh new translation before first saved. It looks like this:

I create and save a cck node in Lang1, with a nodereference field containing some node references; this noderef field is configured as i18nsynched.
I create a translation of this node into Lang2; while I'm editing it, no nodes appear selected in the noderef selection window - I need to redo the selection as I did for Lang1 node. If I don't, nodereference list is emptied for both nodes, Lang2 and Lang1.
After the Lang2 node is already created and saved, changes in the noderef field are i18nsynched properly.

This behavior is similar to an imagefield issue #533228: i18nSynchronization of imagefields using image_fupload widget works only for existing nodes, not for fresh new translations.

Comment #10

orjantorang CreditAttribution: orjantorang commented 22 September 2009 at 12:47

Category:	feature	» bug
Priority:	Normal	» Critical

In my case a translation action gives no opportunity to check (I use checkboxes) any nodereferences, not even when I edit the new node.
I can see the title of the nodereference field but no form fields. In the database field content_field_... there is a NULL value stored. I changed this value
manually and in the view for the node I can now see the nodereferences, but still in edit I can't see any form fields.

I don't know the status of this project, but I have read #573548: Open i18nsync to modules (Open i18nsync to modules) and I think that is a good idea, but also a standard choice in in18n like http://drupal.org/project/node_clone, would be nice.

/Örjan

Comment #11

askibinski CreditAttribution: askibinski commented 11 December 2009 at 12:55

Comment #12

bibo CreditAttribution: bibo commented 29 July 2010 at 19:12

subscribe.

It still seems unclear to me how this should work in the current 1.5 i18nsync version. Apparently it syncs the referenrences' translations on some occasions, but generally it doesnt.

Comment #13

colan

he/him

English

Toronto 🇨🇦

CreditAttribution: colan commented 15 September 2010 at 20:59

Subscribing.

Comment #14

rp7 CreditAttribution: rp7 commented 28 September 2010 at 12:01

Subscribing, this is pretty critical...

Comment #15

varac CreditAttribution: varac commented 5 October 2010 at 10:30

Version:

6.x-1.x-dev

» 6.x-1.7

Subscribing, we have the same problem here (6.x-1.7) and think this is very important to fix !

Comment #16

blaiz CreditAttribution: blaiz commented 18 October 2010 at 18:57

Actually this works for me. I'm synchronizing node references across translations. When I edit the English language one, and save, on the Italian translation, it will search for translated references and save the translated one, if not all referenced pages have been translated, then it will save the English ones instead, which is what I want.

Problem is, when I want to edit the Italian translation then, when I click on Save, it shows an error message stating "Name of the field: this post can't be referenced." for all the ones that reference English pages.And if I delete the English references here, since it's synchronized, it deletes them on the other languages as well.

Is there a way to override this? to force node reference to save even if some references link to another language?

Comment #17

jphil CreditAttribution: jphil commented 9 December 2010 at 15:22

This is really annoying and needs to be fixed ASAP....

Comment #18

Bartezz CreditAttribution: Bartezz commented 23 December 2010 at 14:16

+999

Subscribing

Comment #19

Seighaus CreditAttribution: Seighaus commented 11 January 2011 at 23:38

subscribing

Comment #20

zilverdistel CreditAttribution: zilverdistel commented 1 February 2011 at 15:40

This is my situation:
- node type A refers to node type B (and vice versa).
- node type A is language neutral
- node type B can be Dutch (nl) or English (en).

When I save node of type A, I get the error

  Node type B: this post can't be referenced.

Saving a node of type B succeeds.

Comment #21

Cameron Tod CreditAttribution: Cameron Tod commented 3 February 2011 at 18:01

Is there a similar patch against 6.x-1.7?

Comment #22

stevenator CreditAttribution: stevenator commented 15 February 2011 at 08:41

subscribing

Comment #23

screenage CreditAttribution: screenage commented 16 February 2011 at 10:49

subscribing

Comment #24

ducdebreme CreditAttribution: ducdebreme commented 18 February 2011 at 16:16

subscribing

Comment #25

pedrosp

Madrid, Spain

CreditAttribution: pedrosp commented 23 February 2011 at 17:08

subscribing

Comment #26

zilverdistel CreditAttribution: zilverdistel commented 23 February 2011 at 20:30

we fixed our problem by changing the content negotiation rules on admin/settings/language/i18n to "All content. No language conditions apply." This is just a temporary quickfix that works for us.

Comment #27

YK85 CreditAttribution: YK85 commented 28 February 2011 at 13:00

subscribing

Comment #28

Seighaus CreditAttribution: Seighaus commented 7 March 2011 at 18:36

My Problem (attach language neutral content to translatable content) was solved by this solution: http://drupal.org/node/855102#comment-3404492
Except I don't use a block but node attachment to attach my content.

I hope this helps some of you as well!

Comment #29

zeuty

he/him

Belarusian

Tilburg

CreditAttribution: zeuty commented 9 August 2011 at 09:11

Anything new on this issue?

Comment #30

shreeni2 CreditAttribution: shreeni2 commented 6 December 2011 at 09:36

Component:

Code

» Blocks

subscribing

Comment #31

slucas CreditAttribution: slucas commented 28 December 2011 at 23:13

I've lost some time to understand that this patch have been already applied to current version of i18nsync.
Furthermore to allow node reference of different language to be referenced in a node reference field use view and node language filter to achieve the result you want.
Select the view you've just done in the node reference field settings to select appropriate nodes.
This was quite challenging for me to understand this.
So I write it down here to give clue to others.