Most of the other commands that can be given in the first lines of a message to mail handler are case insensitive, and the name of the taxonomy node in brackets is also case insensitive, but the taxonomy name itself is tested by string equality to 'taxonomy'.

Changing line 255 to compare through strcasecmp rather than == will bring the taxonomy command more in line with the other commands, and on the project I'm supporting, more in line with user expectations:

if ((0==strcasecmp($data[0],'taxonomy')) && !is_numeric($data[1][0])) {

Things currently work, but they work differently for the taxonomy command. This will bring it in line with everything else.

Thanks,

Corprew

Comments

corprew’s picture

corprew commented

(if it's conventient, I can provide this change as a diff or against the relevant repository for approval, I'm just unclear on what the correct procedure is for getting changes approved for modules.)

ilo’s picture

ilo commented
Version: 5.x-1.2 » 6.x-1.x-dev
Category: bug » feature
Issue tags: +Needs tests, +not verified

To be honest I have no idea about the status of the taxonomy integration, but it worths the pain to review and update code or documentation, or both. However this is more about 'usability' than a bug report, if taxonomy is working properly when submitted with the correct case.

danepowell’s picture

danepowell commented
Component: Code » Mailhandler
Status: Active » Closed (won't fix)

Sorry, there won't be any new features in 6.x-1.x unless a new branch maintainer comes along. You can add arbitrary commands in 6.x-2.x, so please consider upgrading.