Make adding IE conditional comments more flexible
doneinstyle - April 12, 2008 - 14:54
| Project: | Zen |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
I humbly suggest you might change the conditional comment in page.tpl.php.
It now reads:
if IE
IE8 is currently in beta. To avoid problems with it and with future versions, and since we can't anticipate what the final IE8 version will fix (or not fix) I suggest that the conditional comment be change to read:
if lte IE 7
That will avoid any issues where hacks for earlier versions will break IE8 rendering.
Love the theme, btw, and I'm making good use of it.
#1
fecking good point.
#2
Prior to the release of IE7, all my sites had
if lt IE 7. I was being optimistic by hoping that IE7 would fix all the layout issues I was experiencing with IE6. However, IE7 turned out to be broken in different ways than IE6 was.But the
if lt IE 7actually turned out to be a problem for me. The sites would break under IE7, and the client would say “why isn't this ie.css file being included by the new IE 7?” If I had left it atif IE, I could have pointed the finger at IE 7.I think a better solution would be to make the IE conditional more flexible for developers to change, but I haven't decided how to do that.
#3
#4
If you use the "if less than or equal to IE7" language, as I initially stated, then people can put things that apply to both IE6 and IE7 in that stylesheet without any hacks, and things that apply to only IE6 and below by using the * html hack. And when IE8 comes out I'm sure the geniuses at css-discuss will come up with a loophole hack, the way they've done for every other version. :) I do this all the time with my other sites. One iestyle.css for all current versions of IE, and that has all the adjustments needed for both.