I got this warning after enabling fivestars in drupal-admin:

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /www/sites/all/modules/fivestar/fivestar.module on line 1367

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /www/sites/all/modules/fivestar/fivestar.module on line 1371

Using fivestar 6.x-1.11-beta5 and votingapi 6x-2.0-beta2, drupal 6.2.
The error appears on top of every page, therefore redirects are broken also...

Comments

mberanek’s picture

mberanek commented

My workaround (untested):

Change lines 1366 - 1372:

function fivestar_views_widget_compact_handler($op, $filter, $value, &$query) {
  return fivestar_views_widget_handler($op, $filter, $value, &$query, FALSE);
}

function fivestar_views_widget_normal_handler($op, $filter, $value, &$query) {
  return fivestar_views_widget_handler($op, $filter, $value, &$query, TRUE);
}

to the following:

function fivestar_views_widget_compact_handler($op, $filter, $value, &$query) {
  return fivestar_views_widget_handler($op, $filter, $value, $query, FALSE);  // modified &$query => $query
}

function fivestar_views_widget_normal_handler($op, $filter, $value, &$query) {
  return fivestar_views_widget_handler($op, $filter, $value, $query, TRUE);  // modified &$query => $query
}
quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Closed (duplicate)

Dear God please stop posting this exact issue. I've closed duplicate issues on this exact issue at least 3 times. This exact problem is currently on the front page of the issue queue. PLEASE READ ISSUES BEFORE POSTING NEW ONES!

http://drupal.org/node/233765

I can't currently release a new version of Fivestar because the Color Picker and new features are still unstable. A new version will be released in the coming weeks.