Is there any reason why you have created this to compete with the already existing and quite-adequate http://drupal.org/project/piclens ?

What additional features are you adding that you don't think could be patched into the existing project?
I mean, you're making a 'lite' version of a module that's only one page long? Huh? What's the motivation here?

Comments

he_who_shall_not_be_named’s picture

Sometimes we have no choice. We must use the integration we have.
Now I am happy. I can choose between to integrations. Great!

FYI: PicLens lite is not PicLens. See PicLens Webmaster's Guide for the details.

dman’s picture

So there really is no actual reason for this module to exist except that more choice makes you happy?

That's not just odd, it's against the Drupal project rules.

Do not try to duplicate functionality because "you don't really like how it's done there". That only adds clutter. Work to improve an existing module rather than introduce yet another random module, as that leads to confusion and frustration for the development, support and end user communities.

If your only reason really is to have duplicated code for the sake of having duplicated code, I'd suggest this be removed altogether. Is there actually no advantage of choosing this one over the other one?

dman’s picture

The existing piclens project includes piclens lite.
So are you saying this module doesn't also support normal piclens full feeds and actually does less than the existing, working one?

he_who_shall_not_be_named’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

As I understand you didn't see the demo. Let me close this discussion.

dman’s picture

Status: Closed (fixed) » Postponed (maintainer needs more info)

I don't want to pick on you, but why close it without answering the question?

Why is this a totally duplicate project? What do you think you've done better or different that you needed to add this entirely new module?

I don't see any advantage from this duplicate module, even from your demo that's not in the Original piclens.module demo
What is the significance of pointing out that it's called "piclens lite" if it's really fully piclens, and just includes the lite version? Because the original project had already got the name? Well, that just shows that problem wasn't that you weren't aware the other one existed (which would be an OK excuse) ... did you see it and decided to double-up the job anyway? OK. I'm sure it was a fun exercise, but isn't it possible that publishing it alongside the earlier one without any explanation of why will be confusing to downloaders?

Too often new modules are contributed that do nothing new, instead, they only do it in a different way. We are then stuck with two modules that offer nearly similar functionality, but neither do it well enough. This leads to confusion, clutter, and a lot of inefficiency.

... To reduce this confusion and clutter, can you describe in any way or reason why a user should choose between the first piclens.module and your version?

michelle’s picture

I'm with dman on this. If you're going to contribute a module that looks like a duplicate of an existing one, you need to put a note on your project page explaining why it's different. There is far too much confusion with modules as it is.

Michelle

he_who_shall_not_be_named’s picture

A note is added to the project page.

I have a 'deja vu' . We had the same discussion when I released the first version of (not so good like now) 'img_filter'. (rejected and refused first, right now the 'img' repository is closed and it was mine. NP)

Few users, especially me, doesn't want 'Image gallery', 'imagecache', 'imagefield', 'Acidfree Albums' or modules which supports them.

I wanted a clean and simple 'PicLens' module. No references to other modules. As you can see, this module is not a duplicate or a clone.

BTW: The 'messenger' was inspired by an existing 'im' Drupal contributed module. Someone duplicated 'messenger' and made a new one from it. So what? I don't care. I'm not scarred. Users won't be scarred because they was and are terrified by a least of 30 image-related modules (are they duplicates?).

Till Drupal will host my modules I'll be happy, after that this modules will be moved somewhere else. If you want me to remove this module, I certainly won't. Must someone else do it for you.

Cheers,
Zoli.

michelle’s picture

As a matter of fact, users are confused by the myriad of media related modules. And any other category where there is a lot of different modules doing similar things. It can be hard to avoid, especially in the area of media where there are so many ways to attack a problem. But there is a big difference between, say, having to choose between the image module and the gallery module than having two modules that interface with Gallery 2. That's the situation here. This is a very specific thing with two very similar modules that will leave users wondering why.

Michelle

dman’s picture

So this is a utility module that's built to extend your img module... Not stand-alone, and not compatible with the other Drupal ways of displaying images and galleries.

Well at least that describes it a little bit. Good start.

I don't want to stifle creativity, and I know it's more fun just making your own modules than it is paying attention to how other folk have done it. But once you see it's been done, you really have to consider working together and contributing, rather than competing and confusing.

Yes, I can see why you would have had objections to your img module. I still can't see what benefit it has over the widely used alternatives, and your project page is incredibly unhelpful to anyone trying to decide which one to use. There are a confusing number of alternative image modules out there, and it's an obstacle to anyone knowing which one is right for them. If you are knowingly going to throw up another module that almost-but-not-quite the same as existing ones, at least describe what's different about it and why anyone should use it on your project page - not just have a meaningless marketing slogan "The easiest way to display images in posts, comments.".
Yep, I'd call it a duplicate, but as long as the pros and cons of that choice are described adequately, I'm not the one to be challenging about removing stuff.

I do still think that what you've got here is 80% duplication of functionality with piclens.module, and that you could easily have got what you wanted by adding just one callback hook to piclens.module ... probably only a few lines long. Maybe your function for turning attachments into a feed could be useful more widely also. Adding hooks for outside modules to talk to is good Drupal practice, and encouraged.

You don't need to be so hostile. Normally when I find developers working on related projects they are happy to find ways in which their modules can be made to work together. Usually just by opening up a few hooks, and resulting in tighter, smaller code.

Hey, somebody's already done something like this - perhaps you should see where that's going, maybe get on board, rather than building your own straw house.

he_who_shall_not_be_named’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

A Drupal user is a Drupal site administrator. He (or she) is not an ordinary user (artist, visitor, gamer, ...). He is not so stupid as you think. He'll take a look into a module's code, eventually hack it, read documentation, make few tests before installs a site.

Both of you are developers and, probably, developed your own sites fighting with ordinary users. I respect you. Let me leave. I beg you, ignore my projects and me. Please.

michelle’s picture

My interest in this has nothing to do with my own sites. I am a drupal.org admin and am looking out for the general population of Drupal users. You can bury your head in the sand if you wish, but this is a huge problem that you are contributing to. Ignoring it will not make it go away.

Michelle

swentel’s picture

As the maintainer of the piclens module this also confuses me big time. I did not release a official version yet of my module because I'm thinking about 2 important things:

  • Moving my mediarss_api file which is now included in my module into a separate project (eg MediaRSS API) with support for hooks etc.
  • Letting my piclens module depend on this new media_rss module with the support I allready have at this point for several image related modules.

If 'd do this, other media modules could profit from the MediaRSS module (it's not only piclens that uses mediarss feeds) and functionality is being seperated. Also, I wouldn't have to support mediarss feeds for say the audio module in my piclens module, that would be extremely confusing.

In fact, I have implemented & tested this allready on my local machine but now I honestly don't know if I should do this now ...

Just my 2 cents.

vm’s picture

it's been handled see: http://drupal.org/node/251354 and follow up there.

he_who_shall_not_be_named’s picture

Priority: Critical » Normal
Status: Closed (fixed) » Active

OK. I'll investigate the Piclens module. See http://drupal.org/node/252268 for the details.

he_who_shall_not_be_named’s picture

Status: Active » Closed (fixed)
dman’s picture

This is all cool by me.
A little bit of centralization of the concepts will pay off for everyone.

Thanks for that vrencianz!

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 251104)