verifyBlogs has two commented out assertions. I'm just reading through the core tests and opening issues for stuff as I see it. Not looked into this yet.

    // View blog help node.
    $this->drupalGet('admin/help/blog');
    $this->assertResponse($response2);
    // NOTE: The two commented asserts fail because the get returns the 'admin/help' node instead of the indicated node???
    if ($response2 == 200) {
//      $this->assertTitle(t('Blog | Drupal'), t('Blog help node was displayed'));
      $this->assertText(t('Blog'), t('Blog help node was displayed'));
//      $this->assertText(t('Home '. $crumb .' Administer '. $crumb .' Help'), t('Breadcrumbs were displayed'));
    }
CommentFileSizeAuthor
#1 251225_1.patch1.13 KBksenzee

Comments

ksenzee’s picture

ksenzee
she/her
commented
Status: Active » Needs review
StatusFileSize
new 251225_1.patch1.13 KB

I uncommented these lines and voilà! They pass. Easiest patch ever. :) However, there are eight more tests failing in blog.test. I'm working on it but have no idea where to report it.

catch’s picture

catch
he/him
Primary language English
commented

ksenzee. I'm pretty sure any issues with tests (bad tests, bad code found by tests, new tests) can all be reported against the core component the tests are against - same as this one. No time to check that patch now, but thanks!

catch’s picture

catch
he/him
Primary language English
commented
Title: blog.test has commented out assertions. » blog.test has eight failures.

edit: mis-post, but leaving the change of title.

Going to re-title this for the eight failures.

catch’s picture

catch
he/him
Primary language English
commented
Component: blog.module » tests

#1 got fixed here:　http://drupal.org/node/257644

Moving to new tests component and back to active.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Active
ksenzee’s picture

ksenzee
she/her
commented

Two of these failures were an actual bug in blog.module (yay! tests ferreting out bugs! who knew!). I've filed a bug report and patch in the blog issue queue at http://drupal.org/node/259496. I think the remaining six failures are a drupalCreateNode() problem. I'll leave this open here until that issue gets resolved.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Critical

Tests not passing is critical.

boombatower’s picture

boombatower commented

This is becoming rather annoying. These tests that keep coming up with failures were all painstaking fixed to ensure that they passed before committing to core. For a list of such tests please see http://groups.drupal.org/node/9408, the list has not been modified after committing to core and stands as a record.

These issues should be checked and dealt with before patches go into core instead of after the fact.

I think the remaining six failures are a drupalCreateNode() problem. I'll leave this open here until that issue gets resolved.

Could be the answer, but only if it has been modified since entering the core or at the sprint without testing.

desbeers’s picture

desbeers commented

Confirmed the problem but found that the problem was that the ‘create blog entries’ was renamed to ‘create blog content’.

As a side result, on the users own blog page, it always said ''You are not allowed to post a new blog entry.' in depended of the permission set or not.

Patch in http://drupal.org/node/259496

Fixing the bug in #6 and makes blog.module passes all test.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Closed (duplicate)

Marking as duplicate of the blog module bug. Test found a bug!