blog.test has eight failures.

catch - April 25, 2008 - 14:55
Project:Drupal
Version:7.x-dev
Component:tests
Category:bug report
Priority:critical
Assigned:Unassigned
Status:duplicate
Description

verifyBlogs has two commented out assertions. I'm just reading through the core tests and opening issues for stuff as I see it. Not looked into this yet.

<?php
   
// View blog help node.
   
$this->drupalGet('admin/help/blog');
   
$this->assertResponse($response2);
   
// NOTE: The two commented asserts fail because the get returns the 'admin/help' node instead of the indicated node???
   
if ($response2 == 200) {
//      $this->assertTitle(t('Blog | Drupal'), t('Blog help node was displayed'));
     
$this->assertText(t('Blog'), t('Blog help node was displayed'));
//      $this->assertText(t('Home '. $crumb .' Administer '. $crumb .' Help'), t('Breadcrumbs were displayed'));
   
}
?>

#1

ksenzee - April 26, 2008 - 15:34
Status:active» patch (code needs review)

I uncommented these lines and voilà! They pass. Easiest patch ever. :) However, there are eight more tests failing in blog.test. I'm working on it but have no idea where to report it.

AttachmentSize
251225_1.patch1.13 KB

#2

catch - April 26, 2008 - 16:01

ksenzee. I'm pretty sure any issues with tests (bad tests, bad code found by tests, new tests) can all be reported against the core component the tests are against - same as this one. No time to check that patch now, but thanks!

#3

catch - May 13, 2008 - 10:38
Title:blog.test has commented out assertions.» blog.test has eight failures.

edit: mis-post, but leaving the change of title.

Going to re-title this for the eight failures.

#4

catch - May 14, 2008 - 22:52
Component:blog.module» tests

#1 got fixed here: http://drupal.org/node/257644

Moving to new tests component and back to active.

#5

catch - May 14, 2008 - 22:54
Status:patch (code needs review)» active

#6

ksenzee - May 17, 2008 - 03:28

Two of these failures were an actual bug in blog.module (yay! tests ferreting out bugs! who knew!). I've filed a bug report and patch in the blog issue queue at http://drupal.org/node/259496. I think the remaining six failures are a drupalCreateNode() problem. I'll leave this open here until that issue gets resolved.

#7

webchick - May 19, 2008 - 01:00
Priority:normal» critical

Tests not passing is critical.

#8

boombatower - May 19, 2008 - 06:09

This is becoming rather annoying. These tests that keep coming up with failures were all painstaking fixed to ensure that they passed before committing to core. For a list of such tests please see http://groups.drupal.org/node/9408, the list has not been modified after committing to core and stands as a record.

These issues should be checked and dealt with before patches go into core instead of after the fact.

I think the remaining six failures are a drupalCreateNode() problem. I'll leave this open here until that issue gets resolved.

Could be the answer, but only if it has been modified since entering the core or at the sprint without testing.

#9

Desbeers - May 21, 2008 - 10:58

Confirmed the problem but found that the problem was that the ‘create blog entries’ was renamed to ‘create blog content’.

As a side result, on the users own blog page, it always said ''You are not allowed to post a new blog entry.' in depended of the permission set or not.

Patch in http://drupal.org/node/259496

Fixing the bug in #6 and makes blog.module passes all test.

#10

catch - May 21, 2008 - 11:14
Status:active» duplicate

Marking as duplicate of the blog module bug. Test found a bug!

 
 

Drupal is a registered trademark of Dries Buytaert.