API type request - Bounty

I'm hoping that other's will pitch in to make it worth someone's while to make a revision to this module for everyone.

Actually - I really like the user interface and the way the module keeps forwarding statistics. I would like to use your module to put up the default forwarding form and, if it's not a node page, a link to a page defined by a variable (or, if the variable is empty, the current page), with the option of overriding the url.

For example:

This URL : www.mysite.com/mymodule/mypage has a forwarding link on it.

When I call the page I set up a variable called LINKTOSEND containing a URL. The forwarding form, realizing we are not on a node page, has a "Send This Link" form with the variable LINKTOSEND populated. If LINKTOSEND isn't populated, the current URL is in the field. The field can be changed by the user.

When the user hits send, the link is listed below your personal message. The page content is not included - just a link to it.

Is this doable?

Thanks, Sean

I also have another suggestion while you are looking at the code. If the forward and the search forms are both on the page at the same time, it creates two divs with ID="edit-submit". I am guessing that it's the default ID on the form API. Anyway, it makes the markup invalid because ID needs to be unique. So if you are into it, maybe you can define the ID for this form as "forward-submit" or another unique identifier. It might be the submit button id. I tried to figure it out but I couldn't see how it worked.

A snip of the code is below:

# </div>
# <input type="hidden" name="nid" id="edit-nid" value="2334" />
# <input type="hidden" name="forward_footer" id="edit-forward-footer" value=" " />
# <input type="submit" name="op" id="edit-submit" value="Send Message" class="form-submit" />
# </fieldset>

Thanks.

edited by: VeryMisunderstood; Added code tags around HTML code so HTML could be read

Thank you -- I posted it elsewhere.

Hi Sean --

I can't test it until this weekend but I think the best you can do about that is to document it to the user. Another alternative is to just email the link to the page but not the content. In that case, all the parameters to the page need to be in the URL (GET vs POST).

It is fine with me because I don't intend to use it for secure data but it is important that the function secure.

I'll let you know how it works for me next week.

Thanks --

Monique.

Hi Sean --

First, I apologize for not getting to this over the weekend. I am still into it. I'll do it Tuesday morning. I'm pretty lame with applying patches. I can't seem to get it worked out without just manually doing it. It will take some time but I'll do it.

Thanks -

Missy.

Hi Sean --

This looks great but I'm running into a couple of problems. I got a reject report when I tried to do the patch. I was able to do most of it manually but not the items below

" ***************
*** 336,345 ****"

I got the email form on the page but I couldn't actually send it because it kept requiring a name and it's probably because I wasn't able to roll in the entire patch. I can see, however, that this is great for anyone who might be doing support or sales because they can forward any page. As it is now (with the correct patch), it probably fulfills what several other users have asked for.

For my use, I need to be able to have the forward module on but have it set up to never show the Email This Page link unless I've included it the module that I'm writing. I looked through the code and couldn't figure out how to do that. If you can give me some guidance, I'd be happy to try it out.

It would be very handy to only have certain roles have the forward link on the nodes but it's probably a lot of work to do that.

So, can you help me include the forward module into a page from a custom module and can you help me figure out how to get the file patched starting from the code below " ***************
*** 336,345 ****"

Thank you!!

Missy.

I got this reject report when I tried to patch it:

***************
*** 34,40 ****
'path' => 'epostcard',
'title' => variable_get('forward_epostcard_title', t('Send an e-Postcard')),
'callback' => 'drupal_get_form',
- 'callback arguments' => array('forward_form'),
'access' => (user_access('access epostcard')),
'type' => MENU_NORMAL_ITEM
);
--- 34,40 ----
'path' => 'epostcard',
'title' => variable_get('forward_epostcard_title', t('Send an e-Postcard')),
'callback' => 'drupal_get_form',
+ 'callback arguments' => array('forward_form', 'epostcard'),
'access' => (user_access('access epostcard')),
'type' => MENU_NORMAL_ITEM
);
***************
*** 91,101 ****
/**
* Implementation of hook_help
*/
- function forward_help($section) {
- switch ($section) {
- case 'epostcard':
- case 'forward/'.arg(1):
- return t(variable_get('forward_instructions', '

'. t('Thank you for your interest in spreading the word on') .' '. variable_get('site_name', 'drupal') .'.

'. t('NOTE: We only request your email address so that the person you are recommending the page to knows that you wanted them to see it, and that it is not junk mail. We do not capture any email address.') .'

'));
}
}

--- 89,104 ----
/**
* Implementation of hook_help
*/
+ function forward_help($path) {
+ if (user_access('access forward') && (preg_match("/^node\//i", $path) == 0) && (variable_get('forward_display_nonnode', false))) {
+ if ($path === NULL) {
+ $path = PRINT_PATH ."/". $_GET['q'];
+ $query = drupal_query_string_encode($_GET, array('q'));
+ if (empty($query)) {
+ $query = NULL;
+ }
+ }
+ return ''. l(t('Email this page'), 'forward/'.$path, NULL, $query) .'';
}
}

***************
*** 336,345 ****
'#required' => true,
);
if (($user->mail) && !user_access('override email address')) {
- $form['message']['yemail']['#disabled'] = true;
- $form['message']['yemail']['#value'] = $user->mail;
}
- $form['message']['yname'] = array(
'#type' => 'textfield',
'#title' => t('Your Name'),
'#default_value' => $user->name,
--- 409,418 ----
'#required' => true,
);
if (($user->mail) && !user_access('override email address')) {
+ $form['yemail']['#disabled'] = true;
+ $form['yemail']['#value'] = $user->mail;
}
+ $form['yname'] = array(
'#type' => 'textfield',
'#title' => t('Your Name'),
'#default_value' => $user->name,

Beauty -- One small bug. The return page for link or forward doesn't appear to be going to the originating page. In all my tests, it returned to www.mysite.com/content. The email came through with the link perfectly. It would probably be prudent to check if you are on an admin page before including the "Email this Page" link.

Another suggestion, in the forward_log table, add a column for URL and populate it with the URL if nid = 0.

Thank you, Sean. Please privately send me your email address or your mailing address.

Missy.

Hi Sean --

I cleared the cache and it still returned to ../content. The test I ran was from a node. I selected Forward this page and it took me to a page with the address ../forward/5. The forward worked fine but it returned me to ../content.

M.

Did you go into the Forward admin page and set it up? Once you get it, can you test it out and let us know how it worked for you? Just put your feedback right here in this thread. Thanks.

Sean --> I'm getting the same error. When I forward a node type page, it goes to ../content. When I forward a non-node page, it goes to a blank page with no headers (aka white screen of death).

Manoloka --> I've attached a screenshot. You can see there are non-node types. This mod is not finished yet but your help and/or testing is welcome.

Manoloka --

I think it's kind of bad form to ask for help and advice on something that's a work in progress. We are trying to get this up and going. Erase it from your server, clear all your caches, put it on your server again and try it. If it works, please test and post your results here. If it doesn't, please wait until you see that it is done. BTW - if really want to see this done, it would be great if you could kick in some $$ for Sean who's been working really hard on it.

Thanks --

Missy.

No bad feelings. Please understand that one does one's best to help by trying to solve the problem that is unique to their system then posting the solution rather than asking others to guess what is wrong. As far as we know, there are only two people who have it installed and neither is having trouble with the admin screen. If you figure it out, please post the solution here.

Sean --> It worked like a charm on your site. I will try to look through the code when I have a chance. If you have any clues or suggest any variables I should watch for that might make it easier for me, please let me know.

Thanks! SMTP and UTIL conflict with this module. That's good to know. I'm sure Sean will take your other ideas into consideration. Thanks for contributing. It is a great help!