This patch implements UI adjustments from the previous mockup as discussed with Gabor.

Please apply from wherever/modules directory. Also, there are 3 attached images that must be added to l10n_community/images.

CommentFileSizeAuthor
#1 l10n_server_ui.patch44.5 KByhahn
#1 icon_approval.gif686 bytesyhahn
#1 icon_copy.gif209 bytesyhahn
#1 icon_toolbox.gif809 bytesyhahn

Comments

yhahn’s picture

StatusFileSize
new809 bytes
new209 bytes
new686 bytes
new44.5 KB

File attachments got lost in the post. Trying again...

gábor hojtsy’s picture

Status: Needs review » Needs work

Great improvements! Thanks for taking this on. Some comments:

- With this patch, we loose the Unicode buttons, which is great, as we get more specific and more platform independent graphics. Thats cool. However, the Unicode buttons were used on the "Explore languages", "Explore projects" and then the overview pages from down there. These table headers are now empty lacking on some text or icon.

- The translation table overview is great! Having textareas and text fields only when needed is great! The compact filter also looks cool.

- When adding a translation, the green checkmark does not work. I'd suppose it is to submit that single translation via AJAX. The red checkmark works to empty the editor area.

- When editing plural strings, the edit buttons have what looks like buggy behavior. You have an edit field per variant, which is expected. But you also have an edit button per variant for the source or the existing translation/suggestion, which I am not sure is great. If you have a language with three variants, you need to click through all three variants' copy buttons to copy them to the edit fields, to avoid submitting empty values there. I'd suggest copy all-or-none buttons, as it is with suggestions for plurals but not with source or translation values now. It would be great to have this consistent.

This is all my feedback so far, keep this patch up, it is badly needed :)

hass’s picture

subscribe

dami’s picture

Thanks for the patch, I like the changes overall. Just one minor thing, when viewing untranslated strings, it's just not as clear as before which ones have suggestions pending. I think we need to find a way to make the star icon more prominent, but not overly so.

As Gabor pointed out, green check mark doesn't work when submitting new translations, although it works when approving suggestions.

dami’s picture

After clicked the magnifying glass to view details, the 'copy source code' button doesn't work. It takes an extra click on the 'view translations' button, to go back to the normal view and to make the 'copy source code' button work again. I can live with it, but being picky, it'd be ideal if the extra step is not needed.

While I am typing this, it comes to my mind that all the new buttons need alt text to be properly identified. It makes it easier for future bug report/review.

robertgarrigos’s picture

subscribing

gábor hojtsy’s picture

Status: Needs work » Fixed

Committed the initial patch to get more attention to this. I am hopeful this would get more eyes working on the minor issues still to be fixed. Moved my issues to http://drupal.org/node/281282 marking this fixed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.