Bugs with the new UI
| Project: | Localization server |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
- We lost the Unicode buttons, which is great, as we got more specific and more platform independent graphics. Thats cool. However, the Unicode buttons were used on the "Explore languages", "Explore projects" and then the overview pages from down there. These table headers are now empty lacking on some text or icon.
- When adding a translation, the green checkmark does not work. I'd suppose it is to submit that single translation via AJAX. The red checkmark works to empty the editor area.
- When editing plural strings, the edit buttons have what looks like buggy behavior. You have an edit field per variant, which is expected. But you also have an edit button per variant for the source or the existing translation/suggestion, which I am not sure is great. If you have a language with three variants, you need to click through all three variants' copy buttons to copy them to the edit fields, to avoid submitting empty values there. I'd suggest copy all-or-none buttons, as it is with suggestions for plurals but not with source or translation values now. It would be great to have this consistent.
#1
BTW this new UI committed recently in http://drupal.org/node/252175
#2
I would like to add (should be split into more bugs later):
- I don't understand the icons and they are missing a tooltip
- After clicking a zoom icon, "Used in:" string appears, but no information. I would expect that clicking that icon will bring back the edition form OR clicking it first time will not even hide it.
- I don't understand the double arrow icon, but it seems it works as an activator for the form.
If anybody suggests a tooltip for every icon, I will try to make a patch...
#3
Next one: Save/Clear buttons are not consistent with others - not themed by l10n_community_button.
#4
Attaching a patch, fixing:
1) Unicode buttons - added a simple text until somebody develops an icon
2) Tooltips for icons
3) Clicking a zoom (Lookup) icon again switches back to translation form
4) Save/Clear are now consistent
"Used in:" bug seems to be dependent on my installation, i may have some tables corrupted (without data).
#5
Patch above has a bug: Clicking Lookup again switches back all forms on page :-) Will fix soon...
#6
Rerolling
#7
Attaching a new patch, trying to solve the plurals problem. The solution is NOT ideal:
- Still has button for every string
- Clicking any of the buttons copies all string parts to all form inputs
To do this, I added a new parameter to the l10n_community_format_text function, named $original. In l10n_community_translate_form, we join the string parts using "; " so the jquery system will automatically detect it as a plural. I still have doubts about this solution, but I wasn't able to develop anything better for now.
To allow having one button for more strings, I think we need to alter format_text function so it either formats a button or not (Format the button for the first one only)
#8
meba: missing patch!
#9
Another bug with the new UI: translation suggestions are passed to check_plain two times, resulting in encoded HTML in the edit box.
#10
Oh great! I deleted all my tarballs with the patch yesterday! :(
#11
Committed #6 (the latest patch) with a slight change in comment with the JS change. I love the convenience feature to toggle the info bar with the magnifier glass. It would be great to open new issues for the other problems, unless someone is proposing an all-in-one patch to fix them (in which case, please reopen this issue).
#12
Submitted http://drupal.org/node/306373 and http://drupal.org/node/306371 as follow ups with the checkmark and plurals editing issues I identified. Also submitted http://drupal.org/node/306374 in Damien's name, so his comment on that bug is preserved. These three issues should keep exposing all problems identified here.
#13
Automatically closed -- issue fixed for two weeks with no activity.