when installing the module the Show Forward on comments is unchecked which is the way I want it.
but the link shows on each comment.

work around is to check and save and then uncheck and save to get it to work correctly.

Comments

seanr’s picture

seanr
he/him
commented
Title: Not Show Forward on comments » Default check for forward_display_comments is inverse of default setting

Please try CVS HEAD and let me know if that works as expected (you'd probably need to delete the row for forward_display_comments from your variables table to test).

dsp1’s picture

dsp1 commented

i suspect that they forward_link function is not finding the forward_display_comments variable and somehow deciding to make it a 1 anyway.

seanr’s picture

seanr
he/him
commented

Did you try the version in CVS HEAD?

thinkyhead’s picture

thinkyhead commented

Comment #2 is correct! Sometimes the module uses variable_get('forward_display_comments', '1') and sometimes it uses variable_get('forward_display_comments', false)... This causes the default value to be "1" in most places, but "0" in the admin form, effectively making the form display the wrong value. This inconsistency exists in the 4.x and 5.x (1.13) versions also.

The fix is to make all instances of variable_get('forward_display_comments', ...) consistent. Personally, I think they should all be changed to variable_get('forward_display_comments', '0') - but who knows, others may prefer it on their comments.

seanr’s picture

seanr
he/him
commented
Status: Active » Fixed

Fixed in all branches; may take a while for packages to update. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.