6.0 update

Yes, I do. If anyone wants to take a crack at the upgrade, I'd be glad to test it out. Might be a little while before we get around to porting it because we're stuck on 5.x right now.

Oh, I just mean that our customers are all on 5.x and we haven't started any serious development using 6. We will at some point, though.

Let us know when you get started and we'll help out!

Can we have a working version for 6x as works for Drupal 7x have already started

It is good if it is in core, which means it will be a 'core module' But even for that it has to be upgraded or rewritten acc. to 6x codes and then 7x codes.

i too would be very happy when this is ported to 6.x i have a lot of content and if they can be sorted alphabetically it would make my users very happy too.

thank you to all the people who thought this should be a part of the core modules, everyone would take advantage of this once they see the possibiities :D

waiting patiently....

Attached is a patch against CVS HEAD which should make Node Order fully compatible with Drupal 6.

The change mainly boils down to

• Replace all form_values by form_state['values']
• Get rid of db_num_rows which doesn't exist anymore in Drupal 6

Additionnaly the order of hook_form_alter parameters changed, and I've fixed a bug with the location of the ajax callback url (previously, it would always be /nodeorder/reordered, which was wrong if the site was installed in a subdirectory).

@bjraines - Have you applied the patch and gotten it to work?

@DeFr - Thank you very much for the patch. It looks like Nodeorder is still dependent upon interface_sortable -- is that correct? Is the drag and drop ordering working?

I look forward to getting the chance to shake this out myself in the next few days. It would be very helpful to me if some other folks who are interested in this were able to do some initial testing.

Thanks again,

Marc

It still depends on interface_sortable (which has a dev release for Drupal 6), which in turns depends on jquery_interface (which only needs a core = 6.x added to the .info to be usable on Drupal 6, not sure why there's no official release, but that's likely related to the module's lack of maintainer).

As far as I can tell the drag & drop ordering works, I've given anonymous the right to re-order nodes here so you should be able to see it in action on http://albus.defr.net/core/drupal-6.4/nodeorder/term/3

Edit: Forgot that you also need to change dependencies to dependencies[] in jquery_interface.info to make it compliant with Drupal 6. Making jQuery Interface officially compatible with Drupal 6 is #208732: Update for Drupal 6.

@DeFr - I was hoping to wait to update this module to use the same drag and drop code that's being used in 6.x core, but it looks like you've got it working using the Interface technology.

Here's what I think would be a good way to go with this. If you are willing to contact JJeff and take over maintenance of the jquery_interface module for 6.x, and if you'll co-maintain interface_sortable with me, then I'd be glad to add you on as a co-maintainer for nodeorder as well. You are our best hope for getting Nodeorder released successfully under 6.x in the near future.

And then, once Nodeorder is released under 6.x, we can branch it and re-write to remove the jquery_interface and interface_sortable dependencies.

What do you think?

- Marc

@bjraines - have you tested out the patch from comment #11 yet? please let us know...

How is the work coming along? I would really like to move to Drupal 6, but I can't do that when nodeorder is not compatible.

I can't get the drag drop functionality to work..am I missing something?

The module loads under Drupal 6.
There is a 'nodeorder' page.
The pink bars are there and the cursor changes into a cross-sign.
But it won't allow me to drag-drop..

@johannes_db - did you apply the patch in #11? what browser are you using? if IE, then try Firefox and let us know the results.

Hey Marcp, thanks a lot for your quick reply!

Apparently it works for me in Firefox (Mac) and Safari (Mac) This is already really great, but I can't ask my clients to all install Firefox..
I've tried in Internet Explorer 7 (PC), but it won't allow me to 'grab' the pink bar..

and yes, i've applied the patches.. but manually.. maybe I did something wrong (?)
If you would be so kind to send me the patched nodeorder.module via email I will be glad to test it for you.. johannes@l-ink.be

Thank you,

Johannes

Johannes - I think someone has a fix for that problem in this issue queue that never got committed. If you have something working on Firefox and Safari, then you have a good start. If you are able to figure out how to get it working in IE in a way that doesn't break Firefox and Safari, then I will gladly apply a patch.

Please dig thru the issue queue and see what you can find. I would really like to see this working on all browsers because it's a useful module, but I don't have the time right now to get it working on IE, so I need help getting the code in place and tested.

Please post back here with your findings (or a plea for help if you can't find anything).

- Marc

Hi Marc,

Apparently it works now in the IE browser of my client :) ..strange that it doesn't work in mine (IE7) and it didn't work last time, but for now it's superb!

Excellent module btw..and a real necessity.

thanks a lot for your help. If it doesn't work anymore i'll look for the post you mentioned..i'm short in time too right now.

Johannes

I'd still like someone else to test the patch and give a full report on how it's working. I'd like to do a 6.x release, but want it to be shaken out before I get going on it.

If someone other than johannes_db or DeFr tests this out and it works, please set status to patch (reviewed & tested by the community).

Also, since nodeorder still depends on jQuery Interface, it would be nice if someone would take over that project and give it an official 6.x release -- there's not much to do to get it out the door.

Would it be possible to make a 6.x version which is entirely independent of the jQuery Update module, the jQuery Interface module, and the jQuery Interface Sortable module? If that's ok, I would like to have a go at it or help in some way.

@pvanderspek - Yes, that would be great. I set out a weak little roadmap in #15, but would be perfectly happy for there to be just one 6.x branch - the one that doesn't depend on any of those other modules, but rather relies upon the same drag and drop code that is being used in core (ie. admin/build/block).

I am not going to get to this in the near future, so please feel free to post your code here when it's ready to be tested by the community. I'll add you as a co-maintainer at that point, if you would like.

- Marc

I'll have a go at it then. I hope to have something to show around New Year. By that time I'll open a separate support ticket for it so that some proper testing can be done.

It's encouraging to see activity on this update thread. Encouraging enough to put forth a question:

Does it seem clear at this point that the general structure of the nodeorder module will stay the same? That is, there will be a column added to [term_node] called 'weight_in_tid' and that there will be a nodeorder tab in the category admin page?

I am planning a site in Drupal 6 and if interest in updating the module has picked up again, I would like to structure my code around the very convenient 'weight_in_tid' column in the the central node table. Thank you!

@Darkle: I currently have a nearly fully functioning version of nodeorder for drupal 6. There are no changes to the database, just to the interface parts to get it to work with the default drupal jQuery and drag-and-drop. So I guess you can go ahead with your plan.

@everyone: the nodeorder-6.x version is almost done. All dependencies on other modules have been removed and the drag-and-drop from core is now being used. There's still one glitch which I need to iron out, before an alpha-release can be provided. I hope to get that ironed out before the end of the year.

@pvanderspek: Thanks for the reassurance -- and thank you for putting the time needed to update this module. I hope that when I'm done with this project I can contribute to the Drupal community as well.

Well, I've made a preliminary version which seems to be working on Drupal 6.8 without any problems. I've attached the code to this post. This is NOT an official release, but those interested can try it and report back any problems.
The nodeorder/order-page might result in a blank page after saving. If this happens, check the files on your server to see if the first character of any of the files is a strange UTF-character. Removing that character should fix the problem.

@pvanderspek - Thank you for getting this out there. I haven't tried it out yet, but will be creating a 6.x branch as soon as I can get some free time.

Everyone else - bring on the feedback.

not sure what i'm doing wrong but when I use this version and click on 'order nodes' (next to 'add term' on top of a vocabularypage) I get this error:

Fatal error: Call to undefined function taxonomy_get_vocabulary() in /sites/all/modules/nodeorder/nodeorder.module on line 596

I used to use the other patched nodeorder from comment #11 and so on without a problem.

grtz

@johannes_db: thanks for trying out the new 6.x version. I've fixed the error you found and it should work now.

Also, I had a chat with marcp and he pointed out to other possible issues: handling of versioned nodes might not work and due to using the drag-and-drop from core weights currently aren't always unique. I will be looking into these two issues this weekend.
Next to that, a 6.x branch will be setup on the nodeorder project page. Until then, please report any problems with the 6.x version in this issue.

Ok, it looks like this version is getting somewhere. A short list of what's changed:

• modified the way in which core drag-and-drop + ordering is used; this requires a change in the database to allow negative weights
• modified the link to the nodeorder/order-page: it is now shown as a tab instead of a regular link on the page. Next to that, tabs which direct to the regular taxonomy page and the nodeorder page have been added
• copied changes from taxonomy-functions to similar nodeorder-functions
• introduced changes to the install-file to comply with the new Schema API and created an initial function which should take care of updating existing nodeorder-installations

Some things do not work or have not been properly tested yet:

• versioned nodes are still not explicitly taken care of
• upgrading existing installations
• uniqueness of weights

Unfortunately, the module posted in #37 failed to install properly:

* warning: Invalid argument supplied for foreach() in /drupal_path/includes/common.inc on line 3279.
* warning: Invalid argument supplied for foreach() in /drupal_path/includes/common.inc on line 3200.

-----

After a little research, it seems that the problem is that drupal_install_schema() only creates tables, but does not modify existing tables. The 'weight_in_tid' column still has to be added manually. Also, hook_schema_alter() still needs to be called to inform the Drupal schema system of the change.

Attached is a patch for nodeorder.install, and also a full tarball of the module. Nothing was changed except for the install script.

Oh btw:
str_replace("darkle", "gunspae");

I'm not sure why that uploaded as *.tar_.gz ... Let's just try renaming the file...

I changed the version on this to 6.x-1.x-dev. There's now a DRUPAL-6--1 branch and there should be a packaged dev version of the module that appears some time today.

In the meantime, it would be great if someone could check that the DRUPAL-6--1 branch in CVS contains the code from gunspae's attachment in the previous comment.

I converted all files to Unix line endings -- please make sure that your editors save in Unix format.

Thanks for everyone's work on this. I'm looking forward to seeing approval of pvanderspek's CVS request!

@gunspae: thanks for fixing my mistakes. I hadn't tested the installation yet. Fortunately I had added a disclaimer to my post ;-)

@marcp: great for getting that CVS branch up and running. Not to be picky or anything, but you might consider marking this as version 2.x of nodeorder. I think that's justified as it isn't really continuing development of the original version for 1.x as the whole drag-and-drop stuff has been replaced by functionality from core. But this is just a suggestion.

I hadn't thought about 6.x-2.x-dev because I'm pretty sure that this is progressing along to be the official 6.x release. If we had decided to make an official release with the old jQuery Interface Sortable dependency, then it would have made sense to have two branches. All our eggs are in this basket!

The D6 version of nodeorder is coming along nicely. It has been rewritten tok work with drag-and-drop from core and some other tweaks have been implemented as well (mostly related to existing feature requests). What it needs now is some rigorous testing. Especially with respect to the installation procedure (which has been rewritten to work with the new Schema API) and working with node revisions. I've created three task-issues related to testing. Please put anything you find in one of those three task-issues:
- installation and upgrading: http://drupal.org/node/356191
- working with node revisions: http://drupal.org/node/356194
- any other remarks: http://drupal.org/node/356197

Pieter - it looks like all the upgrade issues have been closed out. It think it's time for a release -- nice work!

Thanks, Pieter, for getting out the 6.x-1.0 release -- your work is greatly appreciated!

- Marc