Add Folder to status/configuration display [#252832]

I'd like to fetch mail from various folders, all within the same email account. To make it easier to manager, it would be nice to have the folder listed on the status panel (mailhandler_display). The attached patch does that.

Comment	File	Size	Author
#4	mailhandler_add_folder.patch	1.37 KB	z.stolar
#1	mailhandler-showfolder.patch	1.29 KB	jeffmurphy
	mailhandler-showfolder.patch	1.29 KB	jeffmurphy

Comments

Comment #1

jeffmurphy commented 29 April 2008 at 19:58

Status	File	Size
new	mailhandler-showfolder.patch	1.29 KB

I unwittingly reversed the patch. Attached is the correct patch. The change is fairly trivial:

 function mailhandler_display() {
   $destination = drupal_get_destination();
-  $header = array(t('Mailbox'), array('data' => t('Operations'), 'colspan' => 3));
+  $header = array(t('Mailbox'), t('Folder'), array('data' => t('Operations'), 'colspan' => 3));
   $rows = array();
   $result = db_query('SELECT * FROM {mailhandler} ORDER BY mail');
   while ($mailbox = db_fetch_object($result)) {
     $rows[] = array(
       "<a href=\"mailto:$mailbox->mail\">$mailbox->mail</a>",
+      $mailbox->folder,

Comment #2

moshe weitzman commented 2 May 2008 at 17:42

Status:

Needs review

» Needs work

you need to check_plain() that folder before emitting it. we have to protect against xss even in the admin section ... we should add even more info about the mailbox i think.