Dies if command line found with no command

Morbus Iff - May 2, 2008 - 13:30
Project:Mailhandler
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I have an email in the form of:

[... more header stuff ...]
Status: RO
X-Status:
X-Keywords:                   
X-UID: 1

: INTERNET:email@example.com wrote:

> blah blah blah blah

blah blah blah

The first line of the body - starting with :, is improperly considered a Mailhandler command line. Due to lack of input checking, this would then attempt to set $node->'' to the string (since there's no command word here). The attached patch does a check to ensure that the command word exists before attempting to assign to $node. This patch DOES NOT attempt to add the erroneous line back to the body (primarily because I didn't investigate how). I'm not sure your feelings on this.

AttachmentSize
null_command_word.patch757 bytes

#1

Morbus Iff - May 2, 2008 - 13:32
Status:active» needs review

#2

moshe weitzman - May 2, 2008 - 15:07
Status:needs review» patch (to be ported)

committed to D5. Won't apply to D6 ... Thanks.

#3

Morbus Iff - May 2, 2008 - 15:21
Version:5.x-1.x-dev» HEAD
Status:patch (to be ported)» needs review

Same patch. Untested. (Note: there's no Version for 6.x-dev).

AttachmentSize
null_command_word_d6.patch 780 bytes

#4

moshe weitzman - May 2, 2008 - 15:28
Status:needs review» fixed

committed without testing :)

project module still hasn't published the 6.x-dev release so no Version here just yet.

#5

Anonymous (not verified) - May 16, 2008 - 15:32
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.