I have attached a patch that does a bit of cleanup. This is on a fresh cvs checkout of DRUPAL-5.

Things I have done..

1) create a theme function so each user entry in a search results page is themable.
2) updated the search queries to use LOWER() so that searching is a little better.

Please review.

CommentFileSizeAuthor
#1 profileplus_theme_functions_2.patch4.05 KBAnonymous (not verified)
profileplus_theme_functions.patch4.07 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new profileplus_theme_functions_2.patch4.05 KB

forgot to remove debug code.

also forgot to mention i changed the tab label to just be "Users".

davemybes’s picture

davemybes commented
Status: Needs review » Fixed

Thanks Steve. I have done the cleanup - the LOWER does not seem to be necessary, so I left it out for now. I added in my own theme functions, but thanks for the idea to do that. The latest dev versions from today should include all that.

kmeghji’s picture

kmeghji commented

incrn8 - One question on the theming modification you made. From a quick look, it appears that the patch done by Steve themed the whole result item but the modification you made in the latest 5.x version only themes the search result title/link. Am I misunderstanding?

Thanks!

davemybes’s picture

davemybes commented

You're right - I only themed the title. I was going to try and implement both, so that folks could use either theme depending on their needs, but I never got round to implementing that. I'll add it to my todo list.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.