Node Media 6.x Port

What a wonderful contribution, than you for sharing this work. Unfortunately I'm very busy until next month. But if you are interested, I can provide you write access to this module in favor of community.

Blessings!

Thats for the offer, but I'd rather have the maintainers (you and stefano73) review my code before anything is actually put into CVS.

With that, attached is a zip of what I've currently got.

Fixed are:

• File upload limits are now respected

Added:

• A contrib module to integrate the media player from http://www.jeroenwijering.com
• Tentative integration for jQuery Media using http://drupal.org/project/jquery_media

The reason for tentatively using jQuery Media for embedding media is that it allows for embedding of multiple file-types with a simple <a> tag being re-written with the appropriate embedding code. And it currently implements it with http://drupal.org/project/jquery_media since there's no reason to re-implement here.

Attachment	Size
node_media-6x.zip	83.91 KB

We are back in business!

Because The Lord loves you! I got sponsoring for first step: going to stable D5.

Please look at this project home page for more details.

Blessings!

node_media ver. 6.x schema includes the following upload schema files fields: filepath, filemime, filesize, status, timestamp. Is it possible to query files table as an alternative. maybe can use upload table as a reference.

I've thought about this a little, and I don't think it would be that much of an issue to due a join on the files table with the node_media table. Initially it was just easier to use only the node_media table, but that doesn't necessarily make it better. It seems that using the files table would make node_media more drupalish, but my hesitation in doing this is that I'm not sure if there is a distinct advantage to using the files table.

Using of files table preferable in case of holding more then 2 files.
For example if store audio file only 1 file enough but for images it brings possibility to store more then 2 image sizes

@andypost, good point, I'm going to give it a try for 5.x-1.0-alpha2

Blessings!

@andypost

Actually, yes, this makes a lot of sense then. I've been thinking that the amount of image derivatives needs to be more flexible, and I guess this is the way to go...

Attached is what I currently have for the 6.x node_media.

I've changed the schema a bit in this version, moving parts of the older node_media schema into the files table and altering the node_media table a bit.

After fudging around a bit trying to add an entry for each image derivative as a new row in the node_media table, I gave up since the solutions kept looking uglier and uglier. I didn't want to have to resort to any complex joins or re-sorting of data (so that derivative images would reference the original file in the files table and NOT show up as separate files attached to the node) for what should be a simple query.

Currently, I've re-worked the "thumbpath" column to be a little more flexible. It's now called "derivatives" and image derivatives and custom video and audio icons are now stored there as a serialized array. Additional custom-sized derivatives are now possible without adding too much complexity overall, and are also available for use in the javascript inline forms. The total size of the derivatives of each node_media image is kept in the column "derivatives_size" for handy bookkeeping.

The contrib modules have mostly been updated to reflect the changes, but haven't been tested too thoroughly... and apologies for the complete lack of documentation for anyone trying this out...

Again, Not for use on critical sites.

Attachment	Size
node_media.zip	85.28 KB

error during install; schema node_media status field is index but not created.

Oops. Revised zip should be attached. "status" was removed from the table and uses the files status instead now...

Attachment	Size
node_media.zip	85.27 KB

Tested and comments follow:

Provide Link to upload images when creating nodes similar to upload module?

Thumbnail size image hyperlink should show full size image within node page.

Node_media settings for content type should be updated with Node_media derivatives values.

Enabled Node Media Cycle, no slideshow
Enabled Node Media Galleries, no gallery

id in node_media table are not sequential? not sure?

@coupet:

>Provide Link to upload images when creating nodes similar to upload module?

There should be a "Node Media" fieldset on node/add pages to allow for uploading. Unfortunately, I just tested it, and it seems broken right now (nodes do not save correctly after uploading images). The thickbox upload window, if you're using it, should still be working and it has a nondescript "add images" link under the body field (or it should be there, anyway.)

>Thumbnail size image hyperlink should show full size image within node page.

They *should* be linking to the original images. If you're using a modal window like thickbox or lightbox2, the images may be resized to fit your browser. Can you check this by opening the *link* in a new window?

>Node_media settings for content type should be updated with Node_media derivatives values.

Yes, they should. And they will soon, when I get a chance to site down with the code again.

>Enabled Node Media Cycle, no slideshow

Hmmm... The Cycle module is still a little cludgy as it relies on node variables which can't be accessed by filters. At the moment, it does it rewrites in node_alter('view'), and currently only works when the Input Format is set to "Full HTML." Also, I'm not sure what your expectations of the module were, but slideshows currently have to be manually placed by markup like "[slides:[all](size:preview,float:right)]" or what have you. It's possible to implement automatic slideshows (and much easier than manually placing them.) Is that sort of what you had in mind?

>Enabled Node Media Galleries, no gallery

This has me puzzled a bit. No "Image Gallery", "Sound Gallery", or "Video Gallery" tabs at all?

Thanks for the feedback!

> There should be a "Node Media" fieldset on node/add pages to allow for uploading.
yes, file table updated, node table not updated.

> They *should* be linking to the original images.
yes, they are; showing images within page theme would be an alternative.

> slideshows currently have to be manually placed by markup like "[slides:[all](size:preview,float:right)]"
yes, works; thinking of linking thumbnails to Slide Show Frame!

> This has me puzzled a bit. No "Image Gallery", "Sound Gallery", or "Video Gallery" tabs at all?
yes, they show only for Administrator. Also, suggest Gallery Tab show only when more that one media is uploaded for that category

Lightbox2 works pretty well.

Great work, thanks

>yes, they are; showing images within page theme would be an alternative.

To clarify, do you mean showing the full-sized images instead of the thumbnails on node page?

>yes, works; thinking of linking thumbnails to Slide Show Frame!

If I understand this correctly, you mean to have the thumbnails act as buttons to show a larger image in the cycle slideshow, like this: http://www.malsup.com/jquery/cycle/pager2.html ? I will look into this.

>yes, they show only for Administrator. Also, suggest Gallery Tab show only when more that one media is

Oi. Sorry about that. I completely forgot to re-write the access callback for the galleries. I will try to have this resolved soon.

> do you mean showing the full-sized images instead of the thumbnails on node page?
sorry, teaser pictures included in *Listings or Search results* should link to Node page similar to Title of Node.

> have the thumbnails act as buttons to show a larger image in the cycle slideshow,
yes

Current revision to node_media 6.x port:

Fixed (or should be):

• Form caching bug preventing media uploads on node/edit and node/add pages via AHAH forms
• Image sizes on content_type pages should be correct now
• Archive files were inadvertantly let through without node_media_upload_zip enabled. Should be fixed now.

Added:

• Media thumbs can now link to nodes instead of just larger images in teaser view
• Node Media Cycle settings page to set slideshow defaults
• Node Media Cycle setting "thumbs", sets a navigational pager of thumbnails either before or after the slideshow (you'll have to style the css a bit if you want it lookin pretty.)
• Node Media Cycle setting "thumbsize", sets the size of the thumbnails in the navigational pager.

Not dealt with:

• Node Media Gallery Pages. I actually don't like these very much and don't have enough energy at the moment to deal with them. Sorry. Something that bothers me about both the gallery pages and their tabs is that they make things hard to deal with on fixed width sites -- especially with a single module adding 4(!) tabs. I'm inclined to just let them be unless there's some major fuss about them not working...

Attachment	Size
node_media.zip	89.45 KB

Extensive work, Node Media comments follows:

- Images attached when node 1 is created is saved in folder user-3 (user appended with suffix id); Images attached when node 1 is updated is saved in folder 1 (node id). New and Updated Images for same node should be saved in same folder.
- Unable to upload images using IE 6.0; works fine in Firefox
- Create (during edit or cron) new images for existing nodes if Image derivatives settings have been updated after nodes with node_media images were created.
- Suggest Change title in Node Edit Form from Node Media to Media Attachment or Media Upload; more user friendly.

Node Media Cycle
- [slides:[1-5]] works in node pages but display as text in teaser node summary.
- Provide option to include show manually in template node.tpl.php
- Slideshow Float: Clear; reset the node page in IE 6.0
Slideshow Float: Left & Right work fine.

Node Media Upload Zip works great.

Node Media JW Player
- Unable to play media with [nmedia:[1-5]]; error message: The selected file /tmp/fileUgm25A could not be uploaded, because the destination is not properly configured.
- Not sure about ? - Directory where playlist XML is stored node_media_jwplayer_xml

Node Media Inline documentation missing

>Images attached when node 1 is created is saved in folder user-3 (user appended with suffix id); Images attached when node 1 is updated is saved in folder 1 (node id). New and Updated Images for same node should be saved in same folder.

My feeling on this is that there isn't a huge reason for them to be, whereas there was more reason for them not to be. Ideally they *should* be, but I didn't see enough practical reasons for it. Uploading files to a "user" directory allows me to use images inline immediately on a node/add page and uploading files to "node" directory afterwards keeps my "user" directory from getting to be too much of mess. Aside from the mindset of knowing that they're all in the same place, there didn't seem to be a real reason them to be.

>Unable to upload images using IE 6.0; works fine in Firefox

IE6... ugh. I don't currently have a copy to test with, but will when I can... Are you able to upload files using the upload module in IE6?

> Create (during edit or cron) new images for existing nodes if Image derivatives settings have been updated after nodes with node_media images were created.

Maybe... I know this is a feature of the Image module, but I wasn't planning on this.

> Suggest Change title in Node Edit Form from Node Media to Media Attachment or Media Upload; more user friendly.

Agreed.

> [slides:[1-5]] works in node pages but display as text in teaser node summary.

Will take a look at what's going on (probably didn't update the regex...). My feeling right now is to strip the markup from teasers, but I can make this optional if there's interest in showing cycle slideshows in teasers...

> Provide option to include show manually in template node.tpl.php

I wasn't sure if I wanted to make the slideshow as part of the node object... My thinking on this module was that it was more of a "filter"... we'll see though...

> Unable to play media with [nmedia:[1-5]]; error message: The selected file /tmp/fileUgm25A could not be uploaded, because the destination is not properly configured.

I'm not sure why you got an upload error; this module doesn't really do that. What it does is embed the jwplayer and provides XML playlists for the player. "node_media_jwplayer_xml" is the default directory for xml files, which are automatically created on a node view, and cached until a node update. Were you trying to upload something into the "node_media_jwplayer_xml" directory?

> Node Media Inline documentation missing

Yes. Yes, it is. Really, the "inline" name is a misnomer and I've been thinking of renaming it. All that module does is provide a thickbox modal for image uploads on node/edit pages...

- Files table ID is not sequential for zip files uploaded.

- Uninstall node_media does not remove related variables.

- Suggest rename node_media "id" to "nmid"

>Uploading files to a "user" directory vs. uploading files to "node" directory.
In a multiuser environment user directory is good; in a single user environment node directory is better; Should choose one option only if possible. Or optionally move files from user folder to node id folder.

> IE 6.0 upload
With node_media installed, upload with load module does not work either.
Without node_media install, upload with load module works.

> slideshow as part of the node object...
template can be designed and node media files prepositioned in page, then user just upload media.

>I'm not sure why you got an upload error
Image was uploaded, error during view.

- Files table ID is not sequential for zip files uploaded.

This can't be helped so much. The zip file is a temporary file and is assigned a file id at upload, but not saved to the node_media table. Whatever files the zip contains are then processed and are assigned fids which will subsequently come after the zip fid so they won't be perfectly sequential. Since the original zip file isn't set to FILE_STATUS_PERMANENT, the row is cleaned from the files table when cron runs, so no big deal; add to that, since it's a table that records all files saved using file_save_upload, fids in the node_media table are bound to be unsequential anyway.

- Uninstall node_media does not remove related variables.

Will fix in next round.

- Suggest rename node_media "id" to "nmid"

Hmm... This one I'll defer until a maintainer adds some input.

>Uploading files to a "user" directory vs. uploading files to "node" directory.
In a multiuser environment user directory is good; in a single user environment node directory is better; Should choose one option only if possible. Or optionally move files from user folder to node id folder.

Here's the problem: node ids aren't assigned until a node save, which means that files can't be stored in a %nid directory until then, and you think "we'll just move everything there when the node is saved". However, my impetus for uploading on a node/add page was to be able to use images in simple html markup in a node vs. jumping through hoops to use a simple <img> tag (and some of us do prefer using standard html markup for simple things rather than installing filters), and this means that once a file is uploaded and is used in markup it can't be moved without breaking the link, which means re-doing markup -- unnacceptable. On a node/add I needed a predictable place to put files, without dumping *everything* into the node_media directory and the options are, as far as I can tell, are uid and node->type. The node->type didn't seem that much better as the directory will amass the same amount of files, most likely, as the main node_media directory, so I went with uid. %nids are used afterwards just to prevent amassing tons of files in the uid directory. Point is, this was a compromise; uids are used so that files uploaded on node/add pages can be used immediately while keeping some semblance of order, and nids are used afterwards strictly for keeping order. If you want everything in the same directory, it's uids, node->types, or just in the node_media directory as those are the knowns on any given node/add. Moving files around after a node save is not an option as it sort of defeats my goal of being able to upload an image and use an <img> tag which for some reason, drupal lacks an easy way to do. In any case, the point of having things attached to the node is that for all intents and purposes that is where the files exists regardless of what the directory they physically exist is called. Like I said, *ideally* they would be, but for practical reasons things are the way they are.

> IE 6.0 upload
I generally defer IE6 problems until after everything else works on modern browsers. IE6 makes me too angry to focus on anything but how terrible it is, so this will probably persist for a while unless someone else beats me to it.

>template can be designed and node media files prepositioned in page, then user just upload media.
I will consider this, but I can tell you it's not likely. What I'm aiming to do is create flexible tools for inline content, and this is not part of that goal. Honestly, I see more trouble coming from this sort of thing than it's worth as once it's there people will want to be able to configure slideshows per node, and then you go through a whole rigamarole making a table to house slideshow options and the forms to accomplish this...

>Image was uploaded, error during view.
There might be a problem with file_save_data and the xml directory not existing, will take a look in the next round...

Attached should be the current revision of node_media:

Should be fixed:

• node_media uninstall should now remove system variables
• Various changes to the slideshow markup to cycle slideshows, not sure if it fixes anything in IE
• A bunch of other little things

Added:

• Manual regeneration of derivative images
• Cycle slideshows now optionally available in teasers
• tentative contrib integration module for http://www.dynamicdrive.com/dynamicindex4/stepcarousel.htm

Not fixed:

• node_media_galleries
• node_media_jwplayer
• Unsure of IE compatibility

Notes: stepcarousel.js not include in zip, and must be downloaded from: http://www.dynamicdrive.com/dynamicindex4/stepcarousel.htm, patched with the attached stepcarousel patch, and placed in node_media/contrib/node_media_stepcarousel .

Thoughts:
Regarding having cycle slideshows optional placed in a node.tpl.php file: This is already possible without the node_media_cycle module. In node_media_nodeapi(), we have this code in $op = 'view':

So if in your template file you have a function something like MYTEMPLATE_MYNODETYPE_node_media_view(), you can theme $node->node_media to be displayed however you want, be it a cycle slideshow or what have you, and have that manually placed in the node.tpl file as $node_media.

However, this is sort of left over from the 5.x version, and I'm not sure that the function will be recognized it's not part of the theme registry...

Attachment	Size
node_media.zip	101.94 KB
stepcarousel.patch	983 bytes

Thanks for great work, follows are comments:

Node Media review
---------------------
Unable to upload in IE 6.0
- Suggest leveraging code in Upload module

Clicking on Image in page (Node Media Settings - Overlay Library: none)
- Page not found The requested page could not be found

Clicking on image in page (Node Media Settings - Overlay Library: Thickbox)
- Image does not show within frame

Clicking on image in page (Node Media Settings - Overlay Library: Lightbox 2)
- Image does not show within frame

Node Media Cycle review
--------------------------
Node Media Cycle Settings Image Size: Original
- Only part of image (1/4 top left) is shown within frame

Node Media Cycle Settings Image Size: Full
Fatal error: Cannot access empty property in /home/www/www.drupal6x.com/htdocs/drupal-6.2/sites/all/modules/node_media/contrib/node_media_cycle/node_media_cycle.process.inc on line 292

Darly

@btzukuda, I apprecite your effort so much!!
You are doing an excelente work, but this would be much more better for everyone if you commit your work to CVS, so we can follow the "official" development releases guidelines. This way your effort will have better feedback and I'll be able to support it better.

Blessings!

@coupet

quickly:

> Suggest leveraging code in Upload module

Had some time to do some IE6 debugging. It was a javascript issue (having to do with how I was updating some JSON data, vs. the actual upload), and should be working in the next round..

> Clicking on Image in page (Node Media Settings - Overlay Library: none)
> Page not found The requested page could not be found
>
> Clicking on image in page (Node Media Settings - Overlay Library: Thickbox)
> Image does not show within frame
>
> Clicking on image in page (Node Media Settings - Overlay Library: Lightbox 2)
> Image does not show within frame

I wasn't able to reproduce these... (Fresh 6.3 install, along with node_media, jquery_media, jquery_plugin, lightbox, and thickbox)

>Node Media Cycle Settings Image Size: Original
>- Only part of image (1/4 top left) is shown within frame

This is a little bit of a limitation right now. For some reason I haven't gotten cycle's "fit" setting to actually work, and will take a closer look soon. Currently, you'll probably have to set manually set the size of show in order to properly fit the images to the slides wrapper: [slides:[SLIDES](width:XX,height:XX)]

>Node Media Cycle Settings Image Size: Full
>Fatal error: Cannot access empty property in /home/www/www.drupal6x.com/htdocs/drupal->6.2/sites/all/modules/node_media/contrib/node_media_cycle/node_media_cycle.process.inc on line 292

This should be resolved in the next round...

@develCuy

Actually, I was mostly waiting for you to look over the my changes and decide whether or not to commit it to CVS. If, at anytime, you think it's worth committing to CVS, feel free to.

Should be fixed:

• IE6 uploading
• Node view theming function now pattern based to allow for theming node_media_view per content type. ( THEME_node_media_view__CONTENTTYPE($node, $teaser, $page) )
• Some hard coded image paths should be fixed.
• Node Media Cycle: Default slide show size is now based on selected image size, with the ability to override this in markup
• Node Media Cycle: Slide "padding" no longer hard coded.
• Node Media Cycle: The "Cannot access empty property" error
• Node Media Cycle: Moved markup documentation to filter tips since I couldn't quite figure out where to put it...
• Node Media Inline: Can now assign height and width to embedded content via insert forms.

Removed:

• node_media_jwplayer: This was started before jQuery Media was used to embed content inline. It seems a little pointless now, aside from the ability to have playlists, but when you're limited to mp3s,flvs, and jpgs within the node, it seems a little too limited.
• node_media_stepcarousel: honestly, it was just an idea, after a day or two, it didn't seem to be going anywhere.

Attachment	Size
node_media.zip	87.41 KB

JQuery Media dependency requirement is missing from info file?

It seems that it is. Oops!

Upload using IE6: OK
Node Media Cycle: OK

---

Provide option to enable Node Media for each content type or
move: Node Media settings;
Include node media upload form on node edit page? (checked, unchecked)
to Content Type - Node Media settings.

Node Media settings
- Disabled
- Read only
- Read/Write

---

Settings: Teaser Links
If Node Media is shown in teasers, what do they link to?: Link to original Image

Result:
http://192.168.1.201/drupal-6.2/?q=sites/default/files/node_media/user-3... Page not found
- Image is displayed after removing "?q=" from URL

---

Settings: Choose an overlay library to use, if enabled: none
Image format in node body: Thumbnail

Result:
http://192.168.1.201/drupal-6.2/?q=sites/default/files/node_media/user-3... Page not found
- Image is displayed after removing "?q=" from URL
- I think this also affect Thickbox and Lightbox 2 display

Suppose better leave settings in edit content types pages
But if global settings - defaults so we need a /admin/content/node_media
--
upload form imo like tab - more usability in sorting and editing
--
better make links configurable:
teaser - disable|link to gallery
page - before content|after content|template defined|own page
--
thickbox or lightbox should be configurable too

@coupet

> Provide option to enable Node Media for each content type or
> move: Node Media settings;
> Include node media upload form on node edit page? (checked, unchecked)
> to Content Type - Node Media settings.

Yeah, I can see how this could be useful...

> Node Media settings
> - Disabled
> - Read only
> - Read/Write

You'll have to clarify. Would this be per node, per content type, or a global setting?

> Settings: Teaser Links
> If Node Media is shown in teasers, what do they link to?: Link to original Image

Okay. There are issues if clean urls are not enabled... Will take a look.

@andypost:

> thickbox or lightbox should be configurable too

What kind of configuration would they need?

@btsukuda

>@andypost:
>> thickbox or lightbox should be configurable too
>What kind of configuration would they need?

suppose checkbox in global config (enable|disable)

> suppose checkbox in global config (enable|disable)

Would this be different from the global setting "Overlay" (none|thickbox|lightbox2|shadowbox)?

Where is a last version to test? maybe it's time to make dev release?

> Would this be per node, per content type, or a global setting?

Per Content type; change following text:
> Include node media upload form on node edit page? (checked, unchecked)
to
> - Disabled
> - Read only
> - Read/Write

or better as follows:
> - Disabled
> - Enabled

Will there be a dev release? Or is it still to far from that...

Regards,

Marius

Start testing of #27 zip
1) No need to put file_directory_path in _node_media_check_directory

2) node_media_get_sizes returns localized labels so check in node_media_sizes_validate failed on non-english lang

@mariusooms, thanks for the question.

I'm on some troubles for a while, so I'm looking for sponsoring to move this project to D6:
http://nodemedia.chipin.com/nodemedia
http://groups.drupal.org/node/11905

Or if there is some volunteer to co-maintain this module for a while, believe me, all the guys interested on it(including me) will thank you.

Hope to be available soon.

Blessings!

LOL!!! previous post from @jjchristo was done by error, I created that account for a friend, please consider that post as mine.

Blessings!

Did you find funding? I'm unable to contribute through the link offered at the node media front page, here: http://drupal.org/project/node_media , it tells me that the even that the event has ended.

Also, I believe I found a bug in the 6.x release, but I can't choose a higher version besides 5.x-1.x-dev. Would you like for me to post it up here?

Final question, when do you think a full port to 6.x will be released?

dk

@dkleehammer

Thank you a lot for your interest!

I did recreated the ChipIn collect, because has expired.

D6 version is unofficially driven by @btsukuda so it is the only place to report bugs by now.

D6 release is a bit far for now, first goal is to have an stable version for D5 providing a save path to migrate from Node Images. Then I'm going to review this D6 patch for Node Media 2.

Blessings!

@develCuy

I'm unable to donate using Paypal. Here's the message that it is giving to me:

Currently PayPal accounts in Peru are only able to send payments. This recipient is not eligible to receive funds.

@dkleehammer, sorry for the inconveniences, yes, my account can't get payments, but I have a friend with an enabled paypal account so he will "proxy" you donation. Anyway, if you can't wait until next week, you can use money gramm, so please contact me via my contact form or at develcuy.com

Thanks again for your contribution.

Blessings!

Hi @dkleehammer, are you still interested in donation? can I contact you some way?

Blessings!

Bad news: I will not release D6 version.
Good news: I'm going to work on node_media 2.0 for D7, so will reuse patches from this issue.

End of history, closing it(You are welcome to open another issue but for D7)

Blessings!