Warnings on install + .install oddities

Freso - May 6, 2008 - 18:32
Project:G2 Glossary
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description
  • warning: Invalid argument supplied for foreach() in /srv/http/localhost/htdocs/drupal6/includes/common.inc on line 3164.
  • warning: Invalid argument supplied for foreach() in /srv/http/localhost/htdocs/drupal6/includes/common.inc on line 3085.

This is what you currently get when installing G2. These are due to a missing g2_schema() function. But seeing as there isn't one, why are you trying to drupal_install_schema('g2') in the first place? And there shouldn't be a need to define a version (g2_update_6000()) either, until an update is actually needed.

#1

fgm - May 7, 2008 - 06:29
Status:active» postponed

G2 for D6 was created on the D6 betas and not fixed for the final version, which changed things after the code freeze: the schema is in g2.schema, as this was at that time of D6 beta.

As indicated in the release notes, I suggest you not to use the module for D6, because it is going to be largely rewritten following the release for D5, expected this month after a third-party review validates the significant changes brought there.

#2

Freso - May 7, 2008 - 07:30
Status:postponed» needs review

Well, I'm not using G2 yet, just testing. (Well, okay, I guess using it on test sites is also using it, but they're not production sites.) I have this weird habit of testing module before I use them, which gives me a chance to work out bugs and fix bugs before running into them on any given site. It also allows me to make the decision whether or not a given module is ready for being used on a live site.

And... Ah yes, indeed. There it is! I've attached a patch including the _schema in .install and removing the .schema file (fixing some style issues in the affected code while I was at it).

AttachmentSize
g2_schema_in_install.d6.patch 4.43 KB

#3

fgm - May 7, 2008 - 10:56
Status:needs review» postponed

As explained: postponed until new version.

#4

jacopo3001 - July 13, 2008 - 10:05

Hi freso
i am a super newbie to drupal, but still trying to have the G2 running on my test.
would you please tell me how to use your patch file?
please be patient, i am just new...

#5

fgm - July 13, 2008 - 20:33

jacopo: you can follow the instructions at http://drupal.org/node/60108

This being said, the D6 version I mentioned in May is now ready and undergoing internal review before it finished, so if can can wait for some days/weeks, you won't need a patch, and the version will be much better.

#6

koyauni - July 29, 2008 - 09:06

Thanks, I need it very badly for my site. I tried this Glossary.Module but man it made me crazy and I could not figure out where to put terms and where to see the result.
I tried yours but it was too buggy

#7

xurizaemon - July 1, 2009 - 23:30
Status:postponed» needs review

Could you be a little more specific about how many weeks jacopo and others should expect to wait?

It's been 50 weeks so far, and this patch still hasn't made it into the CVS version.

Freso's patch from May 2008 looks good to me.

#8

fgm - July 2, 2009 - 06:05
Status:needs review» postponed

Alas I cannot. Since last year, every time I've though it would be done in the next few days, something has come in the way.

Now, if you like Freso's patch (and it *does* look good), feel free to apply it, as I suggested to jacopo3001, and report on it.

#9

xurizaemon - July 4, 2009 - 13:32
Status:postponed» reviewed & tested by the community

With Freso's patch, the module installs correctly.

Tried installing g2 without Freso's patch; installation failed to add g2 DB tables.

Using g2-Drupal-6--1.

#10

fgm - October 8, 2009 - 10:31
Status:reviewed & tested by the community» fixed

Alternate version committed in today's version, including additional information.

#11

System Message - October 22, 2009 - 10:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.